linux-kernel - drivers/net/wireless/ath/ath9k/hif_usb.c:251:57: warning: suggest braces around empty body in an 'else' statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu, 6 Oct 2022 13:17:50 +0800
From:   kernel test robot <lkp@...el.com>
To:     Pavel Skripkin <paskripkin@...il.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Kalle Valo <quic_kvalo@...cinc.com>
Subject: drivers/net/wireless/ath/ath9k/hif_usb.c:251:57: warning: suggest
 braces around empty body in an 'else' statement

Hi Pavel,

FYI, the error/warning was bisected to this commit, please ignore it if it's irrelevant.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   833477fce7a14d43ae4c07f8ddc32fa5119471a2
commit: d7fc76039b74ad37b7056d5607b05d7cb31a5404 ath9k: htc: clean up statistics macros
date:   4 months ago
config: ia64-randconfig-r005-20221002
compiler: ia64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=d7fc76039b74ad37b7056d5607b05d7cb31a5404
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout d7fc76039b74ad37b7056d5607b05d7cb31a5404
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/net/wireless/ath/ath9k/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   In file included from arch/ia64/include/asm/pgtable.h:153,
                    from include/linux/pgtable.h:6,
                    from arch/ia64/include/asm/uaccess.h:40,
                    from include/linux/uaccess.h:11,
                    from arch/ia64/include/asm/sections.h:11,
                    from include/linux/interrupt.h:21,
                    from include/linux/usb.h:16,
                    from drivers/net/wireless/ath/ath9k/htc.h:21,
                    from drivers/net/wireless/ath/ath9k/hif_usb.c:18:
   arch/ia64/include/asm/mmu_context.h: In function 'reload_context':
   arch/ia64/include/asm/mmu_context.h:127:48: warning: variable 'old_rr4' set but not used [-Wunused-but-set-variable]
     127 |         unsigned long rr0, rr1, rr2, rr3, rr4, old_rr4;
         |                                                ^~~~~~~
   drivers/net/wireless/ath/ath9k/hif_usb.c: In function 'ath9k_skb_queue_complete':
>> drivers/net/wireless/ath/ath9k/hif_usb.c:251:57: warning: suggest braces around empty body in an 'else' statement [-Wempty-body]
     251 |                         TX_STAT_INC(hif_dev, skb_failed);
         |                                                         ^


vim +/else +251 drivers/net/wireless/ath/ath9k/hif_usb.c

   233	
   234	static inline void ath9k_skb_queue_complete(struct hif_device_usb *hif_dev,
   235						    struct sk_buff_head *queue,
   236						    bool txok)
   237	{
   238		struct sk_buff *skb;
   239	
   240		while ((skb = __skb_dequeue(queue)) != NULL) {
   241	#ifdef CONFIG_ATH9K_HTC_DEBUGFS
   242			int ln = skb->len;
   243	#endif
   244			ath9k_htc_txcompletion_cb(hif_dev->htc_handle,
   245						  skb, txok);
   246			if (txok) {
   247				TX_STAT_INC(hif_dev, skb_success);
   248				TX_STAT_ADD(hif_dev, skb_success_bytes, ln);
   249			}
   250			else
 > 251				TX_STAT_INC(hif_dev, skb_failed);
   252		}
   253	}
   254	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (168366 bytes)