linux-kernel - Re: [PATCH] ata: pata_mpc52xx: Replace NO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fcf05af6-fce0-0ac9-c4ff-7b8960bcacc6@opensource.wdc.com>
Date:   Thu, 6 Oct 2022 15:30:49 +0900
From:   Damien Le Moal <damien.lemoal@...nsource.wdc.com>
To:     Christophe Leroy <christophe.leroy@...roup.eu>,
        Sergey Shtylyov <s.shtylyov@....ru>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-ide@...r.kernel.org" <linux-ide@...r.kernel.org>
Subject: Re: [PATCH] ata: pata_mpc52xx: Replace NO_IRQ by 0

On 10/6/22 14:49, Christophe Leroy wrote:
> 
> 
> Le 06/10/2022 à 07:45, Damien Le Moal a écrit :
>> On 10/6/22 14:17, Christophe Leroy wrote:
>>> NO_IRQ is used to check the return of irq_of_parse_and_map().
>>>
>>> On some architecture NO_IRQ is 0, on other architectures it is -1.
>>>
>>> irq_of_parse_and_map() returns 0 on error, independent of NO_IRQ.
>>>
>>> So use 0 instead of using NO_IRQ.
>>>
>>> Signed-off-by: Christophe Leroy <christophe.leroy@...roup.eu>
>>
>> Doesn't this need fixes and cc:stable tags ?
> 
> I don't think so, because the only user of this driver is powerpc and 
> powerpc has NO_IRQ set to 0.
> 
> I'm sending this because I was to remove NO_IRQ in powerpc in a second step.

OK. Got it. So queuing this for 6.2 is OK ? Or do you prefer seeing this
as a "fix" in 6.1 ?

> 
>>
>>> ---
>>>   drivers/ata/pata_mpc52xx.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/ata/pata_mpc52xx.c b/drivers/ata/pata_mpc52xx.c
>>> index 6559b606736d..3ebd6522a1fd 100644
>>> --- a/drivers/ata/pata_mpc52xx.c
>>> +++ b/drivers/ata/pata_mpc52xx.c
>>> @@ -731,7 +731,7 @@ static int mpc52xx_ata_probe(struct platform_device *op)
>>>   		udma_mask = ATA_UDMA2 & ((1 << (*prop + 1)) - 1);
>>>   
>>>   	ata_irq = irq_of_parse_and_map(op->dev.of_node, 0);
>>> -	if (ata_irq == NO_IRQ) {
>>> +	if (!ata_irq) {
>>>   		dev_err(&op->dev, "error mapping irq\n");
>>>   		return -EINVAL;
>>>   	}

-- 
Damien Le Moal
Western Digital Research