linux-kernel - Re: [PATCH] KVM: nVMX: Inject #GP, not #UD, if "generic" VMXON CR0/CR4 check fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yz4fhz3UBJGwOuvN@google.com>
Date:   Thu, 6 Oct 2022 00:21:27 +0000
From:   Sean Christopherson <seanjc@...gle.com>
To:     Paolo Bonzini <pbonzini@...hat.com>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org, Eric Li <ercli@...avis.edu>
Subject: Re: [PATCH] KVM: nVMX: Inject #GP, not #UD, if "generic" VMXON
 CR0/CR4 check fails

On Thu, Oct 06, 2022, Sean Christopherson wrote:
> +	 * Forwarding the VM-Exit unconditionally, i.e. without performing the
> +	 * #UD checks (see above), is functionally ok because KVM doesn't allow
> +	 * L1 to run L2 without CR4.VMXE=0, and because KVM never modifies L2's
> +	 * CR0 or CR4, i.e. it's L2's responsibility to emulate #UDs that are

Grr, s/L2's/L1's.  Fixed the comment locally but didn't commit it before hitting "send".