linux-kernel - Re: [PATCH] PCI: qcom-ep: Fix disabling global

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yz53NnxEkS7hg8Vc@lpieralisi>
Date:   Thu, 6 Oct 2022 08:35:34 +0200
From:   Lorenzo Pieralisi <lpieralisi@...nel.org>
To:     Bjorn Helgaas <helgaas@...nel.org>
Cc:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        kw@...ux.com, bhelgaas@...gle.com, linux-pci@...r.kernel.org,
        robh@...nel.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] PCI: qcom-ep: Fix disabling global_irq in error path

On Wed, Oct 05, 2022 at 12:35:29PM -0500, Bjorn Helgaas wrote:
> On Wed, Oct 05, 2022 at 07:28:52PM +0530, Manivannan Sadhasivam wrote:
> > After commit 6a534df3da88 ("PCI: qcom-ep: Disable IRQs during driver
> > remove"), the global irq is stored in the "global_irq" member of pcie_ep
> > structure. This eliminates the need of local "irq" variable but that
> > commit didn't remove the "irq" variable usage completely and it is still
> > used for disable_irq() in error path which is wrong since the variable is
> > uninitialized.
> > 
> > Fix this by removing the local "irq" variable and using
> > "pcie_ep->global_irq" for disable_irq() in error path.
> > 
> > Reported-by: kernel test robot <lkp@...el.com>
> > Fixes: 6a534df3da88 ("PCI: qcom-ep: Disable IRQs during driver remove")
> > Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> 
> For today's "next" branch, I dropped 6a534df3da88 and the subsequent
> patches.  Hopefully Lorenzo can squash this fix into 6a534df3da88.

Done - the pci/qcom branch successfully passed kbot's tests as well.

Lorenzo