linux-kernel - Re: [PATCH] spi-nand: add Winbond W25N02KV flash support, fix Winbond flashes identifications

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d55465ac-fe0b-130c-31ae-0ce62af3eb5f@kontron.de>
Date:   Thu, 6 Oct 2022 11:26:45 +0200
From:   Frieder Schrempf <frieder.schrempf@...tron.de>
To:     mikhail.kshevetskiy@...sys.eu, linux-kernel@...r.kernel.org,
        linux-mtd@...ts.infradead.org
Cc:     Vignesh Raghavendra <vigneshr@...com>,
        Richard Weinberger <richard@....at>,
        Miquel Raynal <miquel.raynal@...tlin.com>
Subject: Re: [PATCH] spi-nand: add Winbond W25N02KV flash support, fix Winbond
 flashes identifications

Am 06.10.22 um 05:32 schrieb mikhail.kshevetskiy@...sys.eu:
> 
> From: Mikhail Kshevetskiy <mikhail.kshevetskiy@...sys.eu>
> 
> Winbond uses 3 bytes to identify flash: vendor_id, dev_id_0, dev_id_1,
> but current driver uses only first 2 bytes of it for devices
> idenfification. As result Winbond W25N02KV flash (id_bytes: EF, AA, 22)
> is identified as W25N01GV (id_bytes: EF, AA, 21).
> 
> Fix this and add W25N02KV flash support.
> 
> Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@...sys.eu>

Thanks for the patch. We have a similar change in our downstream kernel,
that I failed to push upstream so far. But your version looks even better.

Can you change the subject prefix to "mtd: spinand: winbond:", please?

And I also would like to ask you to split this into two patches. The
first one to add the third byte in the ids of the existing devices and
the second one to add support for the new device.

With these two changes you can add:

Reviewed-by: Frieder Schrempf <frieder.schrempf@...tron.de>