linux-kernel - Re: [PATCH 0/8] soc: mediatek: mtk-svs: refactor and cleanup the driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b15a1fdfaf6d40be8abaa3b0f60a8931c3c356fa.camel@mediatek.com>
Date:   Thu, 6 Oct 2022 19:43:39 +0800
From:   Roger Lu <roger.lu@...iatek.com>
To:     <matthias.bgg@...nel.org>, <jia-wei.chang@...iatek.com>
CC:     <nfraprado@...labora.com>, <khilman@...libre.com>,
        <linux-kernel@...r.kernel.org>,
        <linux-mediatek@...ts.infradead.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <angelogioacchino.delregno@...labora.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Philipp Zabel <p.zabel@...gutronix.de>
Subject: Re: [PATCH 0/8] soc: mediatek: mtk-svs: refactor and cleanup the
 driver

Hi Matthias Sir,

Thanks for sharing these great ideas to improve MTK SVS driver. I've added some
feedback to this patchset. However, should I just submit the v2 of these patches
for you to review? Thanks very much.

Sincerely,
Roger Lu.

On Wed, 2022-09-28 at 17:55 +0200, matthias.bgg@...nel.org wrote:
> From: Matthias Brugger <matthias.bgg@...il.com>
> 
> Mediatek SVS driver got accepted upstream but has coding style issues
> which were overseen in the review process. This series is a first step
> to clean up the driver. It basically cleans up the SoC specific probe.
> As next step we will need to clean up the 'struct svs_bank'.
> 
> This series should be a mere cleanup with no functional change. I'm
> happy to recieve tested-by tags to make sure it does not break anything.
> 
> 
> Matthias Brugger (8):
>   soc: mediatek: mtk-svs: clean up platform probing
>   soc: mediatek: mtk-svs: improve readability of platform_probe
>   soc: mediatek: mtk-svs: move svs_platform_probe into probe
>   soc: mediatek: mtk-svs: delete superfluous platform data entries
>   soc: mediatek: mtk-svs: Move SoC specific functions to new files
>   soc: mtk-svs: mt8183: Move thermal parsing in new function
>   soc: mtk-svs: mt8183: refactor o_slope calculation
>   soc: mtk-svs: mt8192: fix bank data
> 
>  drivers/soc/mediatek/Makefile         |   3 +-
>  drivers/soc/mediatek/mt8183-svs.h     | 113 ++++
>  drivers/soc/mediatek/mt8192-svs.h     |  64 ++
>  drivers/soc/mediatek/mtk-svs-mt8183.c | 235 +++++++
>  drivers/soc/mediatek/mtk-svs-mt8192.c |  98 +++
>  drivers/soc/mediatek/mtk-svs.c        | 882 ++------------------------
>  drivers/soc/mediatek/mtk-svs.h        | 279 ++++++++
>  7 files changed, 853 insertions(+), 821 deletions(-)
>  create mode 100644 drivers/soc/mediatek/mt8183-svs.h
>  create mode 100644 drivers/soc/mediatek/mt8192-svs.h
>  create mode 100644 drivers/soc/mediatek/mtk-svs-mt8183.c
>  create mode 100644 drivers/soc/mediatek/mtk-svs-mt8192.c
>  create mode 100644 drivers/soc/mediatek/mtk-svs.h
>