linux-kernel - Re: [RFT PATCH v3 10/10] iio: Don't silently expect attribute types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 6 Oct 2022 15:53:52 +0300
From:   Matti Vaittinen <mazziesaccount@...il.com>
To:     Claudiu.Beznea@...rochip.com, matti.vaittinen@...rohmeurope.com
Cc:     lars@...afoo.de, Michael.Hennerich@...log.com,
        cosmin.tanislav@...log.com, jic23@...nel.org,
        Eugen.Hristev@...rochip.com, Nicolas.Ferre@...rochip.com,
        alexandre.belloni@...tlin.com, bleung@...omium.org,
        groeck@...omium.org, alexandru.ardelean@...log.com,
        nathan@...nel.org, miquel.raynal@...tlin.com, linmq006@...il.com,
        u.kleine-koenig@...gutronix.de, paul@...pouillou.net,
        mihail.chindris@...log.com, gwendal@...omium.org,
        andriy.shevchenko@...ux.intel.com, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        chrome-platform@...ts.linux.dev
Subject: Re: [RFT PATCH v3 10/10] iio: Don't silently expect attribute types

Hi Claudiu,

On 10/6/22 11:35, Claudiu.Beznea@...rochip.com wrote:
> On 03.10.2022 11:13, Matti Vaittinen wrote:
>> The iio_triggered_buffer_setup_ext() and the
>> devm_iio_kfifo_buffer_setup_ext() were changed by
>> commit 15097c7a1adc ("iio: buffer: wrap all buffer attributes into iio_dev_attr")
>> to silently expect that all attributes given in buffer_attrs array are
>> device-attributes. This expectation was not forced by the API - and some
>> drivers did register attributes created by IIO_CONST_ATTR().
>>
>> When using IIO_CONST_ATTRs the added attribute "wrapping" does not copy
>> the pointer to stored string constant and when the sysfs file is read the
>> kernel will access to invalid location.
>>
>> Change the function signatures to expect an array of iio_dev_attrs to
>> avoid similar errors in the future.
>>
>> Signed-off-by: Matti Vaittinen <mazziesaccount@...il.com>
> 
> Tested-by: Claudiu Beznea <claudiu.beznea@...rochip.com>
> 
> on SAMA5D2
> 

Thanks a ton for the testing! I do _really_ appreciate it :) I am now 
slightly more confident regarding the fix here - and a lot more 
confident that we do have an actual bug (as you explained in the reply 
to the first RFT) :)

Yours
	-- Matti

-- 
Matti Vaittinen
Linux kernel developer at ROHM Semiconductors
Oulu Finland

~~ When things go utterly wrong vim users can always type :help! ~~