linux-kernel - Re: [PATCH] usb: ehci-orion: Extend DMA mask to 64 bit for AC5 platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yz7d9lSUegHE8qR2@rowland.harvard.edu>
Date:   Thu, 6 Oct 2022 09:53:58 -0400
From:   Alan Stern <stern@...land.harvard.edu>
To:     Vadym Kochan <vadym.kochan@...ision.eu>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Elad Nachman <enachman@...vell.com>,
        Yuval Shaia <yshaia@...vell.com>
Subject: Re: [PATCH] usb: ehci-orion: Extend DMA mask to 64 bit for AC5
 platform

On Thu, Oct 06, 2022 at 12:52:57PM +0300, Vadym Kochan wrote:
> From: Elad Nachman <enachman@...vell.com>
> 
> Signed-off-by: Elad Nachman <enachman@...vell.com>
> Signed-off-by: Vadym Kochan <vadym.kochan@...ision.eu>
> ---
>  drivers/usb/host/ehci-orion.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/ehci-orion.c b/drivers/usb/host/ehci-orion.c
> index a3454a3ea4e0..c6205abebbdf 100644
> --- a/drivers/usb/host/ehci-orion.c
> +++ b/drivers/usb/host/ehci-orion.c
> @@ -230,7 +230,7 @@ static int ehci_orion_drv_probe(struct platform_device *pdev)
>  	 * set. Since shared usb code relies on it, set it here for
>  	 * now. Once we have dma capability bindings this can go away.
>  	 */
> -	err = dma_coerce_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32));
> +	err = dma_coerce_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(64));
>  	if (err)
>  		goto err;

Apart from the fact that you didn't include a patch description, how 
come the Subject: line says this applies to the AC5 platform when the 
actual code change applies to all platforms?  Do you know that this 
change is safe for all those other platforms?

Alan Stern