linux-kernel - Re: [PATCH 2/2] PCI: armada8k: Add MSI support for AC5 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202210062207.vnU5tMEI-lkp@intel.com>
Date:   Thu, 6 Oct 2022 22:13:19 +0800
From:   kernel test robot <lkp@...el.com>
To:     Vadym Kochan <vadym.kochan@...ision.eu>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Bjorn Helgaas <helgaas@...nel.org>, linux-pci@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, Elad Nachman <enachman@...vell.com>,
        Yuval Shaia <yshaia@...vell.com>,
        Vadym Kochan <vadym.kochan@...ision.eu>
Subject: Re: [PATCH 2/2] PCI: armada8k: Add MSI support for AC5 SoC

Hi Vadym,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on helgaas-pci/next]
[also build test WARNING on linus/master v6.0 next-20221006]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Vadym-Kochan/PCI-armada8k-Add-support-for-AC5-SoC/20221006-191418
base:   https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: ia64-allyesconfig
compiler: ia64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/51a4773d6d4e6ac65e7ab09f2be643ce6927ce20
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Vadym-Kochan/PCI-armada8k-Add-support-for-AC5-SoC/20221006-191418
        git checkout 51a4773d6d4e6ac65e7ab09f2be643ce6927ce20
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=ia64 SHELL=/bin/bash drivers/pci/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/pci/controller/dwc/pcie-armada8k.c:186:6: warning: no previous prototype for 'ac5_pcie_msi_init' [-Wmissing-prototypes]
     186 | void ac5_pcie_msi_init(struct dw_pcie *pci)
         |      ^~~~~~~~~~~~~~~~~
   drivers/pci/controller/dwc/pcie-armada8k.c:346:33: warning: 'dw_pcie_ops' defined but not used [-Wunused-const-variable=]
     346 | static const struct dw_pcie_ops dw_pcie_ops = {
         |                                 ^~~~~~~~~~~
   {standard input}: Assembler messages:
   {standard input}:451: Error: Register number out of range 0..3
   {standard input}:452: Error: Register number out of range 0..3
   {standard input}:452: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 39
   {standard input}:452: Warning: Only the first path encountering the conflict is reported
   {standard input}:451: Warning: This is the location of the conflicting usage
   {standard input}:453: Error: Register number out of range 0..3
   {standard input}:453: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 39
   {standard input}:453: Warning: Only the first path encountering the conflict is reported
   {standard input}:451: Warning: This is the location of the conflicting usage
   {standard input}:453: Warning: Use of 'mov' violates WAW dependency 'GR%, % in 1 - 127' (impliedf), specific resource number is 39
   {standard input}:453: Warning: Only the first path encountering the conflict is reported
   {standard input}:452: Warning: This is the location of the conflicting usage
   {standard input}:457: Error: Register number out of range 0..3
   {standard input}:1193: Error: Register number out of range 0..6


vim +/ac5_pcie_msi_init +186 drivers/pci/controller/dwc/pcie-armada8k.c

   185	
 > 186	void ac5_pcie_msi_init(struct dw_pcie *pci)
   187	{
   188		u32 val;
   189	
   190		/* Set MSI bit in interrupt mask */
   191		val = dw_pcie_readl_dbi(pci, PCIE_GLOBAL_INT_MASK1_REG);
   192		val |= PCIE_MSI_MASK_AC5;
   193		dw_pcie_writel_dbi(pci, PCIE_GLOBAL_INT_MASK1_REG, val);
   194	}
   195	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (318649 bytes)