linux-kernel - Re: [PATCH] dt-bindings: pinctrl: convert semtech,sx150xq bindings to dt-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 6 Oct 2022 14:06:37 -0500
From:   Rob Herring <robh@...nel.org>
To:     Neil Armstrong <neil.armstrong@...aro.org>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
        devicetree@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: pinctrl: convert semtech,sx150xq bindings
 to dt-schema

On Wed, Oct 05, 2022 at 02:35:36PM +0000, Neil Armstrong wrote:
> This converts the Semtech SX150Xq bindings to dt-schemas, add necessary
> bindings documentation to cover all differences between HW variants
> and current bindings usage.
> 
> Signed-off-by: Neil Armstrong <neil.armstrong@...aro.org>
> ---
> To: Rob Herring <robh+dt@...nel.org>
> To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
> Cc: linux-gpio@...r.kernel.org
> Cc: devicetree@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> ---
>  .../devicetree/bindings/pinctrl/pinctrl-sx150x.txt |  72 -------
>  .../bindings/pinctrl/semtech,sx1501q.yaml          | 207 +++++++++++++++++++++
>  2 files changed, 207 insertions(+), 72 deletions(-)

[...]

> diff --git a/Documentation/devicetree/bindings/pinctrl/semtech,sx1501q.yaml b/Documentation/devicetree/bindings/pinctrl/semtech,sx1501q.yaml
> new file mode 100644
> index 000000000000..5c21f54b0e2b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/semtech,sx1501q.yaml
> @@ -0,0 +1,207 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright 2022 Linaro Ltd.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/pinctrl/semtech,sx1501q.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Semtech SX150x GPIO expander
> +
> +maintainers:
> +  - Neil Armstrong <neil.armstrong@...aro.org>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - semtech,sx1501q
> +      - semtech,sx1502q
> +      - semtech,sx1503q
> +      - semtech,sx1504q
> +      - semtech,sx1505q
> +      - semtech,sx1506q
> +      - semtech,sx1507q
> +      - semtech,sx1508q
> +      - semtech,sx1509q
> +
> +  reg: true

maxItems: 1

Some I2C devices have multiple addresses.

> +
> +  interrupts:
> +    maxItems: 1
> +
> +  '#interrupt-cells':
> +    const: 2
> +
> +  interrupt-controller: true
> +
> +  '#gpio-cells':
> +    const: 2
> +
> +  gpio-controller: true
> +
> +  semtech,probe-reset:
> +    description: Will trigger a reset of the GPIO expander on probe
> +    type: boolean
> +
> +patternProperties:
> +  '-cfg$':
> +    type: object
> +    properties:
> +      pins: true
> +
> +      bias-disable: true
> +      bias-pull-up: true
> +      bias-pull-down: true
> +      bias-pull-pin-default: true
> +      drive-push-pull: true
> +      output-low: true
> +      output-high: true
> +      drive-open-drain: true
> +
> +    required:
> +      - pins
> +
> +    allOf:
> +      - $ref: "pincfg-node.yaml#"
> +      - $ref: "pinmux-node.yaml#"
> +      - if:
> +          properties:
> +            pins:
> +              contains:
> +                const: "oscio"

Don't need quotes

With that,

Reviewed-by: Rob Herring <robh@...nel.org>