linux-kernel - Re: [PATCH 5/8] dt-bindings: watchdog: mediatek: Convert mtk-wdt to json-schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 7 Oct 2022 08:31:48 +0000
From:   Allen-KH Cheng (程冠勳) 
        <Allen-KH.Cheng@...iatek.com>
To:     "wim@...ux-watchdog.org" <wim@...ux-watchdog.org>,
        "linux@...ck-us.net" <linux@...ck-us.net>,
        "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
        "krzysztof.kozlowski@...aro.org" <krzysztof.kozlowski@...aro.org>,
        "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "nfraprado@...labora.com" <nfraprado@...labora.com>
CC:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-mediatek@...ts.infradead.org" 
        <linux-mediatek@...ts.infradead.org>,
        "angelogioacchino.delregno@...labora.com" 
        <angelogioacchino.delregno@...labora.com>,
        Project_Global_Chrome_Upstream_Group 
        <Project_Global_Chrome_Upstream_Group@...iatek.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH 5/8] dt-bindings: watchdog: mediatek: Convert mtk-wdt to
 json-schema

Hi Krzysztof,

On Fri, 2022-10-07 at 09:25 +0200, Krzysztof Kozlowski wrote:
> On 06/10/2022 14:07, Allen-KH Cheng wrote:
> 
> Thank you for your patch. There is something to discuss/improve.
> 
> 
> > +  - Matthias Brugger <matthias.bgg@...il.com>
> > +
> > +description:
> > +  The watchdog supports a pre-timeout interrupt that fires
> > +  timeout-sec/2 before the expiry.
> > +
> > +allOf:
> > +  - $ref: watchdog.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    oneOf:
> > +      - items:
> > +          - enum:
> 
> This is just one enum in "items", so no need for the "items".
> 

Got it, I will drop this for v2.

Thanks,
Allen


> > +              - mediatek,mt2712-wdt
> > +              - mediatek,mt6589-wdt
> > +              - mediatek,mt7986-wdt
> > +              - mediatek,mt8183-wdt
> > +              - mediatek,mt8186-wdt
> > +              - mediatek,mt8192-wdt
> > +              - mediatek,mt8195-wdt
> 
> Best regards,
> Krzysztof
>