[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9e14ae09-6100-a55f-7aa7-6ed9edb49e09@collabora.com>
Date: Fri, 7 Oct 2022 11:07:56 +0200
From: AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>
To: Moudy Ho <moudy.ho@...iatek.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
Matthias Brugger <matthias.bgg@...il.com>,
Hans Verkuil <hverkuil-cisco@...all.nl>
Cc: Chun-Kuang Hu <chunkuang.hu@...nel.org>,
linux-media@...r.kernel.org, linux-mediatek@...ts.infradead.org,
linux-kernel@...r.kernel.org,
Project_Global_Chrome_Upstream_Group@...iatek.com
Subject: Re: [PATCH v1 1/6] media: platform: mtk-mdp3: add chip configuration
header file
Il 07/10/22 05:17, Moudy Ho ha scritto:
> In order to be compatible with more MDP3 chip settings in the future,
> move the chip-related configuration to a separate header file.
>
> Signed-off-by: Moudy Ho <moudy.ho@...iatek.com>
> ---
> .../media/platform/mediatek/mdp3/mt8183_mdp.h | 35 +++++++++++++++++++
What if we choose a better name format for the chip header?
Would mdp3-plat-mt8183.h work for you?
Aside from that, the changes look good... but anyway, what this driver
really needs is an abstraction of `mtk-img-ipi.h` since, as you know, new
SoCs are using a different firmware and even a different architecture for
the MCU.
Is that planned?
I think that such change would perfectly fit inside of this series.
Regards,
Angelo
> .../platform/mediatek/mdp3/mtk-mdp3-core.c | 27 ++------------
> 2 files changed, 37 insertions(+), 25 deletions(-)
> create mode 100644 drivers/media/platform/mediatek/mdp3/mt8183_mdp.h
>
Powered by blists - more mailing lists