linux-kernel - Re: [PATCH v13 5/5] leds: flash: mt6370: Add MediaTek MT6370 flashlight support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 7 Oct 2022 12:19:18 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     ChiaEn Wu <peterwu.pub@...il.com>
Cc:     pavel@....cz, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, matthias.bgg@...il.com,
        jic23@...nel.org, lars@...afoo.de, chiaen_wu@...htek.com,
        alice_chen@...htek.com, cy_huang@...htek.com,
        linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-iio@...r.kernel.org, szunichen@...il.com
Subject: Re: [PATCH v13 5/5] leds: flash: mt6370: Add MediaTek MT6370
 flashlight support

On Fri, Oct 07, 2022 at 09:28:17AM +0800, ChiaEn Wu wrote:
> On Wed, Oct 5, 2022 at 8:15 PM Andy Shevchenko
> <andriy.shevchenko@...ux.intel.com> wrote:

...

> > > +config LEDS_MT6370_FLASH
> > > +     tristate "Flash LED Support for MediaTek MT6370 PMIC"
> >
> > > +     depends on LEDS_CLASS && OF
> >
> > Why do you have OF dependency?
> >
> 
> Hi Andy,
> The original idea is to use the "fwnode_property_*" related function.
> But this side may only consider just "Build Pass" (?)

Yes, you increase a compile test coverage by dropping that dependency.

> I will remove "OF" in the v14 patch.

-- 
With Best Regards,
Andy Shevchenko