| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <65d83f3e-b0ce-c199-c653-c948b9f015b5@roeck-us.net>
Date: Fri, 7 Oct 2022 05:53:38 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Allen-KH Cheng <allen-kh.cheng@...iatek.com>,
Wim Van Sebroeck <wim@...ux-watchdog.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Matthias Brugger <matthias.bgg@...il.com>,
Rob Herring <robh+dt@...nel.org>, nfraprado@...labora.com
Cc: angelogioacchino.delregno@...labora.com,
Project_Global_Chrome_Upstream_Group@...iatek.com,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH v2 5/8] dt-bindings: watchdog: mediatek: Convert mtk-wdt
to json-schema
On 10/7/22 02:34, Allen-KH Cheng wrote:
> From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
>
> Convert the MediaTek watchdog bindings to schema.
>
> The original binding only had 4 without a fallback but there is a reset
> controller on the "mediatek,mt7986-wdt", "mediatek,mt8186-wdt" and
> "mediatek,mt8195-wdt". Since there is no reset controller for the mt6589,
> we remove "mediatek,mt6589-wdt" as a fallback.
>
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
> Co-developed-by: Allen-KH Cheng <allen-kh.cheng@...iatek.com>
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@...iatek.com>
Reviewed-by: Guenter Roeck <linux@...ck-us.net>
> ---
> .../bindings/watchdog/mediatek,mtk-wdt.yaml | 77 +++++++++++++++++++
> .../devicetree/bindings/watchdog/mtk-wdt.txt | 42 ----------
> 2 files changed, 77 insertions(+), 42 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml
> delete mode 100644 Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
>
> diff --git a/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml b/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml
> new file mode 100644
> index 000000000000..6805fbeace11
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/mediatek,mtk-wdt.yaml
> @@ -0,0 +1,77 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/watchdog/mediatek,mtk-wdt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek SoCs Watchdog timer
> +
> +maintainers:
> + - Matthias Brugger <matthias.bgg@...il.com>
> +
> +description:
> + The watchdog supports a pre-timeout interrupt that fires
> + timeout-sec/2 before the expiry.
> +
> +allOf:
> + - $ref: watchdog.yaml#
> +
> +properties:
> + compatible:
> + oneOf:
> + - enum:
> + - mediatek,mt2712-wdt
> + - mediatek,mt6589-wdt
> + - mediatek,mt7986-wdt
> + - mediatek,mt8183-wdt
> + - mediatek,mt8186-wdt
> + - mediatek,mt8192-wdt
> + - mediatek,mt8195-wdt
> + - items:
> + - enum:
> + - mediatek,mt2701-wdt
> + - mediatek,mt6582-wdt
> + - mediatek,mt6797-wdt
> + - mediatek,mt7622-wdt
> + - mediatek,mt7623-wdt
> + - mediatek,mt7629-wdt
> + - mediatek,mt8516-wdt
> + - const: mediatek,mt6589-wdt
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + items:
> + - description: Watchdog pre-timeout (bark) interrupt
> +
> + mediatek,disable-extrst:
> + description: Disable sending output reset signal
> + type: boolean
> +
> + '#reset-cells':
> + const: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
> +
> + watchdog: watchdog@...07000 {
> + compatible = "mediatek,mt8183-wdt";
> + reg = <0 0x10007000 0 0x100>;
> + interrupts = <GIC_SPI 139 IRQ_TYPE_LEVEL_LOW>;
> + mediatek,disable-extrst;
> + timeout-sec = <10>;
> + #reset-cells = <1>;
> + };
> + };
> diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> deleted file mode 100644
> index 762c62e428ef..000000000000
> --- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> +++ /dev/null
> @@ -1,42 +0,0 @@
> -Mediatek SoCs Watchdog timer
> -
> -The watchdog supports a pre-timeout interrupt that fires timeout-sec/2
> -before the expiry.
> -
> -Required properties:
> -
> -- compatible should contain:
> - "mediatek,mt2701-wdt", "mediatek,mt6589-wdt": for MT2701
> - "mediatek,mt2712-wdt": for MT2712
> - "mediatek,mt6582-wdt", "mediatek,mt6589-wdt": for MT6582
> - "mediatek,mt6589-wdt": for MT6589
> - "mediatek,mt6797-wdt", "mediatek,mt6589-wdt": for MT6797
> - "mediatek,mt7622-wdt", "mediatek,mt6589-wdt": for MT7622
> - "mediatek,mt7623-wdt", "mediatek,mt6589-wdt": for MT7623
> - "mediatek,mt7629-wdt", "mediatek,mt6589-wdt": for MT7629
> - "mediatek,mt7986-wdt", "mediatek,mt6589-wdt": for MT7986
> - "mediatek,mt8183-wdt": for MT8183
> - "mediatek,mt8186-wdt", "mediatek,mt6589-wdt": for MT8186
> - "mediatek,mt8516-wdt", "mediatek,mt6589-wdt": for MT8516
> - "mediatek,mt8192-wdt": for MT8192
> - "mediatek,mt8195-wdt", "mediatek,mt6589-wdt": for MT8195
> -
> -- reg : Specifies base physical address and size of the registers.
> -
> -Optional properties:
> -- mediatek,disable-extrst: disable send output reset signal
> -- interrupts: Watchdog pre-timeout (bark) interrupt.
> -- timeout-sec: contains the watchdog timeout in seconds.
> -- #reset-cells: Should be 1.
> -
> -Example:
> -
> -watchdog: watchdog@...07000 {
> - compatible = "mediatek,mt8183-wdt",
> - "mediatek,mt6589-wdt";
> - mediatek,disable-extrst;
> - reg = <0 0x10007000 0 0x100>;
> - interrupts = <GIC_SPI 139 IRQ_TYPE_NONE>;
> - timeout-sec = <10>;
> - #reset-cells = <1>;
> -};
Powered by blists - more mailing lists