linux-kernel - Re: [EXT] Re: [PATCH v5 2/2] misc: nxp-sr1xx: UWB driver support for sr1xx series chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 7 Oct 2022 19:49:34 +0530
From:   Manjunatha Venkatesh <manjunatha.venkatesh@....com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     linux-kernel@...r.kernel.org, will@...nel.org, axboe@...nel.dk,
        robh+dt@...nel.org, mb@...htnvm.io, ckeepax@...nsource.cirrus.com,
        arnd@...db.d, mst@...hat.com, javier@...igon.com,
        mikelley@...rosoft.com, jasowang@...hat.com,
        sunilmut@...rosoft.com, bjorn.andersson@...aro.org,
        krzysztof.kozlowski+dt@...aro.org, devicetree@...r.kernel.org,
        ashish.deshpande@....com, rvmanjumce@...il.com
Subject: Re: [EXT] Re: [PATCH v5 2/2] misc: nxp-sr1xx: UWB driver support for
 sr1xx series chip


On 9/14/2022 8:25 PM, Greg KH wrote:
> Caution: EXT Email
>
> On Wed, Sep 14, 2022 at 07:59:44PM +0530, Manjunatha Venkatesh wrote:
>> +/**
>> + * sr1xx_dev_transceive
>> + * @op_mode indicates write/read operation
>> + *
>> + * Write and Read logic implemented under same api with
>> + * mutex lock protection so write and read synchronized
>> + *
>> + * During Uwb ranging sequence(read) need to block write sequence
>> + * in order to avoid some race condition scenarios.
>> + *
>> + * Returns     : Number of bytes write/read if read is success else (-1)
> I'm sure I mentioned this before, but NEVER use magic "-1" as an error
> value.  Use the real in-kernel -ERROR numbers for error codes please.
> This needs to be fixed in many places in this code.
Will fix this in the next patch submission.
> thanks,
>
> greg k-h