linux-kernel - Re: [PATCH v5] MIPS: Expose prid and globalnumber to sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <b3886864-5c54-4524-8e30-b6701553b615@app.fastmail.com>
Date:   Fri, 07 Oct 2022 17:37:34 +0100
From:   "Jiaxun Yang" <jiaxun.yang@...goat.com>
To:     "Greg KH" <greg@...ah.com>
Cc:     "linux-mips@...r.kernel.org" <linux-mips@...r.kernel.org>,
        linux-kernel@...r.kernel.org,
        "Thomas Bogendoerfer" <tsbogend@...ha.franken.de>,
        linux-api@...r.kernel.org, f.fainelli@...il.com
Subject: Re: [PATCH v5] MIPS: Expose prid and globalnumber to sysfs



在2022年10月7日十月 下午3:52，Greg KH写道：
[...]
>> +
>> +static int cpuregs_cpu_offline(unsigned int cpu)
>> +{
>> +	struct device *dev;
>> +	struct cpureg *reg = per_cpu(cpuregs, cpu);
>> +
>> +	dev = get_cpu_device(cpu);
>> +	if (!dev || !reg)
>> +		return -ENODEV;
>> +	if (reg->kobj.parent) {
>
> Why are you looking at the parent of a kobject?  Why not just always
> remove the kobject if you have a reference to it now?  How does the
> parent matter?

Another dummy copy from Arm64 code... kobject_put should be enough here?

Thanks

>
> thanks,
>
> greg k-h

-- 
- Jiaxun