linux-kernel - Re: [PATCH v9 2/2] iio: adc: ad4130: add AD4130 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 7 Oct 2022 10:45:41 +0800
From:   kernel test robot <lkp@...el.com>
To:     Cosmin Tanislav <demonsingur@...il.com>
Cc:     kbuild-all@...ts.01.org, Jonathan Cameron <jic23@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        linux-iio@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        Cosmin Tanislav <cosmin.tanislav@...log.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>
Subject: Re: [PATCH v9 2/2] iio: adc: ad4130: add AD4130 driver

Hi Cosmin,

I love your patch! Perhaps something to improve:

[auto build test WARNING on jic23-iio/togreg]
[also build test WARNING on robh/for-next linus/master v6.0 next-20221006]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Cosmin-Tanislav/AD4130/20221006-221313
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
reproduce:
        # https://github.com/intel-lab-lkp/linux/commit/4b905b5c6b166dc9ea13246096c2d044648105b0
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Cosmin-Tanislav/AD4130/20221006-221313
        git checkout 4b905b5c6b166dc9ea13246096c2d044648105b0
        make menuconfig
        # enable CONFIG_COMPILE_TEST, CONFIG_WARN_MISSING_DOCUMENTS, CONFIG_WARN_ABI_ERRORS
        make htmldocs

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> Documentation/ABI/testing/sysfs-bus-iio-adc-ad4130:2: WARNING: Unexpected indentation.
>> Documentation/ABI/testing/sysfs-bus-iio-adc-ad4130:2: WARNING: Block quote ends without a blank line; unexpected unindent.

vim +2 Documentation/ABI/testing/sysfs-bus-iio-adc-ad4130

   > 2	KernelVersion:	6.0
     3	Contact:	linux-iio@...r.kernel.org
     4	Description:
     5			Reading returns a list with the possible filter modes.
     6			"sinc4"       - Sinc 4. Excellent noise performance. Long 1st
     7					conversion time. No natural 50/60Hz rejection.
     8			"sinc4+sinc1" - Sinc4 + averaging by 8. Low 1st conversion time.
     9			"sinc3"	      - Sinc3. Moderate 1st conversion time. Good noise
    10					performance.
    11			"sinc3+rej60" - Sinc3 + 60Hz rejection. At a sampling frequency
    12					of 50Hz, achieves simultaneous 50Hz and 60Hz
    13					rejection.
    14			"sinc3+sinc1" - Sinc3 + averaging by 8. Low 1st conversion time.
    15					Best used with a sampling frequency of at least
    16					216.19Hz.
    17			"sinc3+pf1"   - Sinc3 + Post Filter 1.
    18					53dB rejection @ 50Hz, 58dB rejection @ 60Hz.
    19			"sinc3+pf2"   - Sinc3 + Post Filter 2.
    20					70dB rejection @ 50Hz, 70dB rejection @ 60Hz.
    21			"sinc3+pf3"   - Sinc3 + Post Filter 3.
    22					99dB rejection @ 50Hz, 103dB rejection @ 60Hz.
    23			"sinc3+pf4"   - Sinc3 + Post Filter 4.
    24					103dB rejection @ 50Hz, 109dB rejection @ 60Hz.
    25	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (38492 bytes)