linux-kernel - Re: [PATCH 5/6] x86/gsseg: move load_gs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6CBB0EC9-5EF1-4396-9B5F-C0A5592BFD37@zytor.com>
Date:   Fri, 07 Oct 2022 10:43:34 -0700
From:   "H. Peter Anvin" <hpa@...or.com>
To:     Brian Gerst <brgerst@...il.com>, Xin Li <xin3.li@...el.com>
CC:     linux-kernel@...r.kernel.org, x86@...nel.org, tglx@...utronix.de,
        mingo@...hat.com, bp@...en8.de, dave.hansen@...ux.intel.com
Subject: Re: [PATCH 5/6] x86/gsseg: move load_gs_index() to its own header file

On October 7, 2022 8:40:41 AM PDT, Brian Gerst <brgerst@...il.com> wrote:
>On Thu, Oct 6, 2022 at 12:13 PM Xin Li <xin3.li@...el.com> wrote:
>>
>> From: "H. Peter Anvin (Intel)" <hpa@...or.com>
>>
>> <asm/cpufeature.h> depends on <asm/special_insns.h>, so in order to be
>> able to use alternatives in native_load_gs_index(), factor it out into
>> a separate header file.
>>
>> Signed-off-by: H. Peter Anvin (Intel) <hpa@...or.com>
>> Signed-off-by: Xin Li <xin3.li@...el.com>
>
>This could be moved into <asm/segment.h> instead of creating a new header file.
>
>--
>Brian Gerst

At least at the time I wrote the code, it could not, without creating yet another circular header file dependency.