linux-kernel - Re: [RFC PATCH 00/21] block: add and use init tagset helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y0BvRaVO0iUVmHgB@bombadil.infradead.org>
Date:   Fri, 7 Oct 2022 11:26:13 -0700
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     Chaitanya Kulkarni <kch@...dia.com>
Cc:     linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-omap@...r.kernel.org, linux-remoteproc@...r.kernel.org,
        linux-mmc@...r.kernel.org, linux-mtd@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-nvme@...ts.infradead.org, linux-s390@...r.kernel.org,
        linux-scsi@...r.kernel.org, axboe@...nel.dk, efremov@...ux.com,
        josef@...icpanda.com, idryomov@...il.com,
        dongsheng.yang@...ystack.cn, haris.iqbal@...os.com,
        jinpu.wang@...os.com, mst@...hat.com, jasowang@...hat.com,
        pbonzini@...hat.com, stefanha@...hat.com, ohad@...ery.com,
        andersson@...nel.org, baolin.wang@...ux.alibaba.com,
        ulf.hansson@...aro.org, richard@....at, miquel.raynal@...tlin.com,
        vigneshr@...com, marcan@...can.st, sven@...npeter.dev,
        alyssa@...enzweig.io, kbusch@...nel.org, hch@....de,
        sagi@...mberg.me, sth@...ux.ibm.com, hoeppner@...ux.ibm.com,
        hca@...ux.ibm.com, gor@...ux.ibm.com, agordeev@...ux.ibm.com,
        borntraeger@...ux.ibm.com, svens@...ux.ibm.com, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, hare@...e.de, bhelgaas@...gle.com,
        john.garry@...wei.com, christophe.jaillet@...adoo.fr,
        vaibhavgupta40@...il.com, wsa+renesas@...g-engineering.com,
        damien.lemoal@...nsource.wdc.com, johannes.thumshirn@....com,
        bvanassche@....org, ming.lei@...hat.com,
        shinichiro.kawasaki@....com, vincent.fu@...sung.com,
        christoph.boehmwalder@...bit.com, joel@....id.au,
        vincent.whitchurch@...s.com, nbd@...er.debian.org,
        ceph-devel@...r.kernel.org,
        virtualization@...ts.linux-foundation.org, asahi@...ts.linux.dev
Subject: Re: [RFC PATCH 00/21] block: add and use init tagset helper

On Tue, Oct 04, 2022 at 08:22:36PM -0700, Chaitanya Kulkarni wrote:
> Hi,
> 
> Add and use the helper to initialize the common fields of the tag_set
> such as blk_mq_ops, number of h/w queues, queue depth, command size,
> numa_node, timeout, BLK_MQ_F_XXX flags, driver data. This initialization
> is spread all over the block drivers. This avoids repetation of
> inialization code of the tag set in current block drivers and any future
> ones.
> 
> P.S. I'm aware of the EXPORT_SYMBOL_GPL() checkpatch warn just to make
> get some feedback to so I can remove the RFC tag.
> 

*If* there were commonalities at init and these could be broken up into
common groups, each having their own set of calls, then we simplify and
can abstract these. I say this without doing a complete review of the
removals, but if there really isn't much of commonalities I tend to
agree with Bart that open coding this is better.

  Luis