linux-kernel - Re: [PATCH 1/3] xen/virtio: restructure xen grant dma setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <127d2641-2f5d-893f-dc81-3c6d52bc78ce@suse.com>
Date:   Fri, 7 Oct 2022 06:35:28 +0200
From:   Juergen Gross <jgross@...e.com>
To:     Oleksandr Tyshchenko <Oleksandr_Tyshchenko@...m.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Cc:     Stefano Stabellini <sstabellini@...nel.org>,
        "xen-devel@...ts.xenproject.org" <xen-devel@...ts.xenproject.org>
Subject: Re: [PATCH 1/3] xen/virtio: restructure xen grant dma setup

On 06.10.22 18:35, Oleksandr Tyshchenko wrote:
> 
> On 06.10.22 10:14, Juergen Gross wrote:
> 
> Hello Juergen
> 
>> In order to prepare supporting other means than device tree for
>> setting up virtio devices under Xen, restructure the functions
>> xen_is_grant_dma_device() and xen_grant_setup_dma_ops() a little bit.
>>
>> Signed-off-by: Juergen Gross <jgross@...e.com>
> 
> 
> Patch looks good,
> 
> one NIT, xen_dt_grant_setup_dma_ops() down the code doesn't actually
> setup DMA OPS, it retrieves the backend domid via device-tree means and
> stores it,
> 
> so I would rename to it, maybe something like
> xen_dt_grant_setup_backend_domid() or xen_dt_grant_init_backend_domid(),
> but I am not sure it would be good alternative.

I'll go with xen_dt_grant_init_backend_domid().

> 
> 
> So, w/ or w/o renaming:
> 
> Reviewed-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@...m.com>
> 
> also
> 
> Tested-by: Oleksandr Tyshchenko <oleksandr_tyshchenko@...m.com> # Arm64
> only

Thanks,


Juergen


Download attachment "OpenPGP_0xB0DE9DD628BF132F.asc" of type "application/pgp-keys" (3099 bytes)

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (496 bytes)