linux-kernel - Re: [PATCH -next] x86/tsc: Make art_related

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2a887f96-93d4-90ed-cfc4-61e895b102cf@huawei.com>
Date:   Sat, 8 Oct 2022 16:47:35 +0800
From:   chenlifu <chenlifu@...wei.com>
To:     <tglx@...utronix.de>, <mingo@...hat.com>, <bp@...en8.de>,
        <dave.hansen@...ux.intel.com>, <x86@...nel.org>, <hpa@...or.com>,
        <feng.tang@...el.com>, <gregkh@...uxfoundation.org>,
        <peterz@...radead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] x86/tsc: Make art_related_clocksource static

在 2022/8/23 10:18, Chen Lifu 写道:
> The symbol is not used outside of the file, so mark it static.
> 
> Fixes the following warning:
> 
> arch/x86/kernel/tsc.c:53:20: warning:
> 	symbol 'art_related_clocksource' was not declared. Should it be static?
> 
> Signed-off-by: Chen Lifu <chenlifu@...wei.com>
> ---
>   arch/x86/kernel/tsc.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kernel/tsc.c b/arch/x86/kernel/tsc.c
> index cafacb2e58cc..a78e73da4a74 100644
> --- a/arch/x86/kernel/tsc.c
> +++ b/arch/x86/kernel/tsc.c
> @@ -49,11 +49,11 @@ static DEFINE_STATIC_KEY_FALSE(__use_tsc);
>   int tsc_clocksource_reliable;
>   
>   static u32 art_to_tsc_numerator;
>   static u32 art_to_tsc_denominator;
>   static u64 art_to_tsc_offset;
> -struct clocksource *art_related_clocksource;
> +static struct clocksource *art_related_clocksource;
>   
>   struct cyc2ns {
>   	struct cyc2ns_data data[2];	/*  0 + 2*16 = 32 */
>   	seqcount_latch_t   seq;		/* 32 + 4    = 36 */
>   

friendly ping ...