linux-kernel - [PATCH linux-next] scsi: myrb: replace !strcmp with sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20221008084907.309320-1-ye.xingchen@zte.com.cn>
Date:   Sat,  8 Oct 2022 08:49:07 +0000
From:   yexingchen116@...il.com
To:     martin.petersen@...cle.com
Cc:     hare@...nel.org, jejb@...ux.ibm.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org, ye xingchen <ye.xingchen@....com.cn>
Subject: [PATCH linux-next] scsi: myrb: replace !strcmp with sysfs_streq

From: ye xingchen <ye.xingchen@....com.cn>

Replace the open-code with sysfs_streq().

Signed-off-by: ye xingchen <ye.xingchen@....com.cn>
---
 drivers/scsi/myrb.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/myrb.c b/drivers/scsi/myrb.c
index e885c1dbf61f..7f269b90c9e4 100644
--- a/drivers/scsi/myrb.c
+++ b/drivers/scsi/myrb.c
@@ -1813,12 +1813,12 @@ static ssize_t raid_state_store(struct device *dev,
 	enum myrb_devstate new_state;
 	unsigned short status;
 
-	if (!strncmp(buf, "kill", 4) ||
-	    !strncmp(buf, "offline", 7))
+	if (sysfs_streq(buf, "kill") ||
+	    sysfs_streq(buf, "offline"))
 		new_state = MYRB_DEVICE_DEAD;
-	else if (!strncmp(buf, "online", 6))
+	else if (sysfs_streq(buf, "online"))
 		new_state = MYRB_DEVICE_ONLINE;
-	else if (!strncmp(buf, "standby", 7))
+	else if (sysfs_streq(buf, "standby"))
 		new_state = MYRB_DEVICE_STANDBY;
 	else
 		return -EINVAL;
-- 
2.25.1