linux-kernel - Re: [PATCH 4/5] ksm: count zero pages for each process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 8 Oct 2022 21:55:34 +0800
From:   kernel test robot <lkp@...el.com>
To:     xu.xin.sc@...il.com, akpm@...ux-foundation.org
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, xu xin <xu.xin16@....com.cn>,
        Claudio Imbrenda <imbrenda@...ux.ibm.com>,
        David Hildenbrand <david@...hat.com>,
        Xuexin Jiang <jiang.xuexin@....com.cn>,
        Xiaokai Ran <ran.xiaokai@....com.cn>,
        Yang Yang <yang.yang29@....com.cn>
Subject: Re: [PATCH 4/5] ksm: count zero pages for each process

Hi,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on akpm-mm/mm-everything]
[also build test WARNING on next-20221007]
[cannot apply to linus/master v6.0]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/xu-xin-sc-gmail-com/ksm-support-tracking-KSM-placed-zero-pages/20221008-150936
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
config: i386-randconfig-a002-20221003
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/73e535667af6553c5f6317da4d8034e79557417b
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review xu-xin-sc-gmail-com/ksm-support-tracking-KSM-placed-zero-pages/20221008-150936
        git checkout 73e535667af6553c5f6317da4d8034e79557417b
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> mm/ksm.c:550:4: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation]
                           rmap_item->mm->ksm_zero_pages_sharing--;
                           ^
   mm/ksm.c:548:3: note: previous statement is here
                   if (!unshare_zero_pages(rmap_item))
                   ^
   1 warning generated.


vim +/if +550 mm/ksm.c

   544	
   545	static inline void free_rmap_item(struct ksm_rmap_item *rmap_item)
   546	{
   547		if (rmap_item->address & ZERO_PAGE_FLAG) {
   548			if (!unshare_zero_pages(rmap_item))
   549				ksm_zero_pages_sharing--;
 > 550				rmap_item->mm->ksm_zero_pages_sharing--;
   551		}
   552		ksm_rmap_items--;
   553		rmap_item->mm->ksm_rmap_items--;
   554		rmap_item->mm = NULL;   /* debug safety */
   555		kmem_cache_free(rmap_item_cache, rmap_item);
   556	}
   557	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (154205 bytes)