linux-kernel - Re: [PATCH v4] ath9k: verify the expected usb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 08 Oct 2022 22:10:16 +0200
From:   Johannes Berg <johannes@...solutions.net>
To:     Fedor Pchelkin <pchelkin@...ras.ru>,
        Toke Høiland-Jørgensen <toke@...e.dk>,
        Kalle Valo <kvalo@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Alexey Khoroshilov <khoroshilov@...ras.ru>,
        lvc-project@...uxtesting.org,
        Alan Stern <stern@...land.harvard.edu>
Subject: Re: [PATCH v4] ath9k: verify the expected usb_endpoints are present

On Sat, 2022-10-08 at 15:02 +0300, Fedor Pchelkin wrote:
>  
> +	/* Verify the expected endpoints are present */
> +	alt = interface->cur_altsetting;
> +	if (usb_find_common_endpoints(alt, &bulk_in, &bulk_out, &int_in, &int_out) < 0 ||
> +			usb_endpoint_num(bulk_in) != USB_WLAN_RX_PIPE ||
> +			usb_endpoint_num(bulk_out) != USB_WLAN_TX_PIPE ||
> +			usb_endpoint_num(int_in) != USB_REG_IN_PIPE ||
> +			usb_endpoint_num(int_out) != USB_REG_OUT_PIPE) {
> +			dev_err(&udev->dev,
> +					"ath9k_htc: Device endpoint numbers are not the expected ones\n");
> +		return -ENODEV;
> 

Indentation somehow got pretty messed up now ..

johannes