linux-kernel - Re: [PATCH] docs: ftrace: Correct access mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221008161928.7098b068@rorschach.local.home>
Date:   Sat, 8 Oct 2022 16:19:28 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Leo Yan <leo.yan@...aro.org>
Cc:     Ingo Molnar <mingo@...hat.com>, Jonathan Corbet <corbet@....net>,
        linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] docs: ftrace: Correct access mode

On Sat,  8 Oct 2022 08:32:50 +0000
Leo Yan <leo.yan@...aro.org> wrote:

> The documentation gives an example for opening trace marker with
> write-only mode, but the flag WR_ONLY is not defined by glibc.
> 
> Use O_WRONLY to replace it.
> 
> Signed-off-by: Leo Yan <leo.yan@...aro.org>
> ---
>  Documentation/trace/ftrace.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/trace/ftrace.rst b/Documentation/trace/ftrace.rst
> index b37dc19e4d40..60bceb018d6a 100644
> --- a/Documentation/trace/ftrace.rst
> +++ b/Documentation/trace/ftrace.rst
> @@ -564,7 +564,7 @@ of ftrace. Here is a list of some of the key files:
>  
>  	start::
>  
> -		trace_fd = open("trace_marker", WR_ONLY);
> +		trace_fd = open("trace_marker", O_WRONLY);

Acked-by: Steven Rostedt (Google) <rostedt@...dmis.org>

-- Steve

>  
>  	Note: Writing into the trace_marker file can also initiate triggers
>  	      that are written into /sys/kernel/tracing/events/ftrace/print/trigger