linux-kernel - Re: [PATCH v2 7/9] cpufreq: amd_pstate: add AMD Pstate EPP support for the MSR based processors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202210091946.GxEInFut-lkp@intel.com>
Date:   Sun, 9 Oct 2022 19:26:05 +0800
From:   kernel test robot <lkp@...el.com>
To:     Perry Yuan <Perry.Yuan@....com>, rafael.j.wysocki@...el.com,
        ray.huang@....com, viresh.kumar@...aro.org
Cc:     kbuild-all@...ts.01.org, Deepak.Sharma@....com,
        Mario.Limonciello@....com, Nathan.Fontenot@....com,
        Alexander.Deucher@....com, Shimmer.Huang@....com,
        Xiaojian.Du@....com, Li.Meng@....com, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, Perry Yuan <Perry.Yuan@....com>
Subject: Re: [PATCH v2 7/9] cpufreq: amd_pstate: add AMD Pstate EPP support
 for the MSR based processors

Hi Perry,

I love your patch! Perhaps something to improve:

[auto build test WARNING on rafael-pm/linux-next]
[also build test WARNING on tip/x86/core v6.0]
[cannot apply to linus/master next-20221007]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Perry-Yuan/Implement-AMD-Pstate-EPP-Driver/20221009-151325
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: x86_64-allyesconfig
compiler: gcc-11 (Debian 11.3.0-5) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/25572929f89d2f4c44fa79dcf0a30c18182c3162
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Perry-Yuan/Implement-AMD-Pstate-EPP-Driver/20221009-151325
        git checkout 25572929f89d2f4c44fa79dcf0a30c18182c3162
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/cpufreq/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/cpufreq/amd-pstate.c: In function 'update_boost_state':
>> drivers/cpufreq/amd-pstate.c:998:29: warning: variable 'cpudata' set but not used [-Wunused-but-set-variable]
     998 |         struct amd_cpudata *cpudata;
         |                             ^~~~~~~


vim +/cpudata +998 drivers/cpufreq/amd-pstate.c

   994	
   995	static inline void update_boost_state(void)
   996	{
   997		u64 misc_en;
 > 998		struct amd_cpudata *cpudata;
   999	
  1000		cpudata = all_cpu_data[0];
  1001		rdmsrl(MSR_AMD_CPPC_HW_CTL, misc_en);
  1002		global_params.cppc_boost_disabled = misc_en & AMD_CPPC_PRECISION_BOOST_ENABLED;
  1003	}
  1004	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (289516 bytes)