linux-kernel - Re: [PATCH] drm/tve200: Use drm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAABMjtGFKK2EJojFMqzMPmRfcJzo1yzdOqDVT804WnhOQ1O79Q@mail.gmail.com>
Date:   Sun, 9 Oct 2022 08:15:03 +0600
From:   Khalid Masum <khalid.masum.92@...il.com>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     David Airlie <airlied@...ux.ie>, Daniel Vetter <daniel@...ll.ch>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/tve200: Use drm_* variants for logging

On Tue, Oct 4, 2022 at 12:54 AM Linus Walleij <linus.walleij@...aro.org> wrote:
>
> On Wed, Sep 28, 2022 at 11:31 AM Khalid Masum <khalid.masum.92@...il.com> wrote:
>
> > We have routines like drm_info/warn/err for logging. Use them instead
> > of dev_* variants to get drm-formatted log messages.
> >
> > Signed-off-by: Khalid Masum <khalid.masum.92@...il.com>
>
> So is this the new thing? We've been through:
> - DRM_INFO_ETC BIG CAPITAL LETTER MACROS
> - Just use dev_info() & friends like everyone else
> - Now drm_info() & co
>
> Note I don't wanna bikeshed about this, just tell me there is
> consensus now so we know what to do.

Hi,

I was working on a TODO described here:
https://github.com/torvalds/linux/blob/master/Documentation/gpu/todo.rst#convert-logging-to-drm_-functions-with-drm_device-paramater

"Convert logging to drm_* functions with drm_device paramater". I do not
know of any consensus by the way.

>
> Yours,
> Linus Walleij

Thanks,
  -- Khalid Masum