linux-kernel - Re: [PATCH -next] power: supply: mt6370: Fix Kconfig dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b725c6eb-1026-a010-1e93-50af9a96a0a4@huawei.com>
Date:   Sun, 9 Oct 2022 21:34:33 +0800
From:   Ren Zhijie <renzhijie2@...wei.com>
To:     ChiaEn Wu <peterwu.pub@...il.com>, <sre@...nel.org>,
        <andy.shevchenko@...il.com>, <chiaen_wu@...htek.com>
CC:     <linux-pm@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] power: supply: mt6370: Fix Kconfig dependency

Hi,

just a friendly ping...

Ren

在 2022/9/22 17:58, ChiaEn Wu 写道:
> On 9/22/2022 10:33 AM, Ren Zhijie wrote:
>> If CONFIG_IIO is not set,
>> make ARCH=x86_64 CROSS_COMPILE=x86_64-linux-gnu-,
>> will be failed, like this:
>>
>> drivers/power/supply/mt6370-charger.o: In function 
>> `mt6370_chg_mivr_dwork_func':
>> mt6370-charger.c:(.text+0x670): undefined reference to 
>> `iio_read_channel_processed'
>> drivers/power/supply/mt6370-charger.o: In function `mt6370_chg_probe':
>> mt6370-charger.c:(.text+0xb43): undefined reference to 
>> `devm_iio_channel_get_all'
>> make: *** [vmlinux] Error 1
>>
>> To fix this build error, add depends on IIO to config CHARGER_MT6370 
>> dependency.
>>
>> Fixes: 233cb8a47d65 ("power: supply: mt6370: Add MediaTek MT6370 
>> charger driver")
>> Signed-off-by: Ren Zhijie <renzhijie2@...wei.com>
>> ---
>>   drivers/power/supply/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig
>> index 591deb82e2c6..62111f4bb093 100644
>> --- a/drivers/power/supply/Kconfig
>> +++ b/drivers/power/supply/Kconfig
>> @@ -623,6 +623,7 @@ config CHARGER_MT6370
>>       tristate "MediaTek MT6370 Charger Driver"
>>       depends on MFD_MT6370
>>       depends on REGULATOR
>> +    depends on IIO
>>       select LINEAR_RANGES
>>       help
>>         Say Y here to enable MT6370 Charger Part.
>
> Hi Ren,
>
> Thanks for catching this!
>
> Reviewed-by: ChiaEn Wu <chiaen_wu@...htek.com>
>