lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Sun, 9 Oct 2022 08:12:11 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Li zeming <zeming@...china.com>
Cc:     mcgrof@...nel.org, yzaikin@...gle.com,
        linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH] proc: Remove unnecessary ‘NULL’ and '0' values

On Sat, Oct 08, 2022 at 05:30:26PM +0800, Li zeming wrote:
> Remove unnecessary initialization assignments, which are used after the
> assignment.

They don't hurt anything, and in fact show the intent of the initial
variable state. Additionally, the compiler will drop it once it finds
the later assignment.

-Kees

-- 
Kees Cook

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ