linux-kernel - Re: Ping: [PATCH -next v3 0/2] Remove unused variables in x86/boot

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202210090815.526C76396@keescook>
Date:   Sun, 9 Oct 2022 08:17:20 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Li Zetao <lizetao1@...wei.com>
Cc:     tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
        dave.hansen@...ux.intel.com, x86@...nel.org, hpa@...or.com,
        kirill.shutemov@...ux.intel.com, akpm@...ux-foundation.org,
        michael.roth@....com, nathan@...nel.org,
        sathyanarayanan.kuppuswamy@...ux.intel.com, masahiroy@...nel.org,
        ndesaulniers@...gle.com, brijesh.singh@....com,
        peterz@...radead.org, venu.busireddy@...cle.com,
        linux-kernel@...r.kernel.org
Subject: Re: Ping: [PATCH -next v3 0/2] Remove unused variables in x86/boot

On Sat, Oct 08, 2022 at 09:41:59PM +0800, Li Zetao wrote:
> On 2022/9/30 11:27, Li Zetao wrote:
> > This series removes some unused variables in x86/boot, and add the
> > "-Wall" flag to Makefile, which is the old problem of x86 not sharing
> > makefiles.
> > 
> > Changes since v2:
> > - Add "frame-address" flag and "-std=gnu11" to
> >    x86/boot/compressed/Makefile to fix warnings when "-Wall" flag added.
> > - Declare the variable "i" within the for loop to reslove unused
> >    variable warning.
> > - Delete __efi_get_rsdp_addr function when CONFIG_EFI is disabled to
> >    resolve unused function warning.

Nathan suggested earlier (and I agree): please re-order these patches so
the fixes for the new warnings are first, and then turn on the compiler
flags in a final patch. This will keep the build "warning free" at all
steps.

-- 
Kees Cook