linux-kernel - Re: [PATCH v1 1/1] mfd: syscon: Remove repetition of the regmap_get_val

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221009163942.GA630814@roeck-us.net>
Date:   Sun, 9 Oct 2022 09:39:42 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     linux-kernel@...r.kernel.org, Lee Jones <lee@...nel.org>,
        Arnd Bergmann <arnd@...db.de>, regressions@...ts.linux.dev
Subject: Re: [PATCH v1 1/1] mfd: syscon: Remove repetition of the
 regmap_get_val_endian()

On Mon, Aug 08, 2022 at 05:08:11PM +0300, Andy Shevchenko wrote:
> Since the commit 0dbdb76c0ca8 ("regmap: mmio: Parse endianness
> definitions from DT") regmap MMIO parses DT itsef, no need to
> repeat this in the caller(s).
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

This patch results in reboot failures for all big endian mips emulations.

Sample log:

Network interface test passed
Boot successful.
Rebooting
reboot: Restarting system
Unable to restart system
Reboot failed -- System halted

The problem is not seen with little endian mips emulations. Reverting
this patch fixes the problem. Bisect log attached.

#regzbot introduced: 72a95859728a
#regzbot title: Reboot failure on big endian mips systems

Guenter

---
# bad: [a6afa4199d3d038fbfdff5511f7523b0e30cb774] Merge tag 'mailbox-v6.1' of git://git.linaro.org/landing-teams/working/fujitsu/integration
# good: [4c86114194e644b6da9107d75910635c9e87179e] Merge tag 'iomap-6.1-merge-1' of git://git.kernel.org/pub/scm/fs/xfs/xfs-linux
git bisect start 'HEAD' '4c86114194e6'
# bad: [6181073dd6a7e5deafc60e7981bd765b6c93da8c] Merge tag 'tty-6.1-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty
git bisect bad 6181073dd6a7e5deafc60e7981bd765b6c93da8c
# bad: [94e8ca6ebd1bc20a193eb552dee4de884a954938] Merge tag 'rproc-v6.1' of git://git.kernel.org/pub/scm/linux/kernel/git/remoteproc/linux
git bisect bad 94e8ca6ebd1bc20a193eb552dee4de884a954938
# good: [9d84bb40bcb30a7fa16f33baa967aeb9953dda78] Merge tag 'drm-next-2022-10-07-1' of git://anongit.freedesktop.org/drm/drm
git bisect good 9d84bb40bcb30a7fa16f33baa967aeb9953dda78
# good: [5d435a3f7b6cb1db566d0f56f5f8dc33be0dde69] Merge tag 'media/v6.1-1' of git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-media
git bisect good 5d435a3f7b6cb1db566d0f56f5f8dc33be0dde69
# bad: [ae9559594cb851aff774d5bea243b84c6acf761d] Merge tag 'mfd-next-6.1' of git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd
git bisect bad ae9559594cb851aff774d5bea243b84c6acf761d
# good: [834382ea32865a4bdeae83ec2dcb9321dc9489f2] mfd: da9061: Fix Failed to set Two-Wire Bus Mode.
git bisect good 834382ea32865a4bdeae83ec2dcb9321dc9489f2
# good: [2f5b0059b31a3e554cb8c5a40682411a2f53f4d3] Merge branch 'for-6.1/nintendo' into for-linus
git bisect good 2f5b0059b31a3e554cb8c5a40682411a2f53f4d3
# good: [430257d8329b58170a92364597e474fa607e28b2] Merge branch 'for-6.1/uclogic' into for-linus
git bisect good 430257d8329b58170a92364597e474fa607e28b2
# good: [cb7c02e91c31f55d08760f04a09bf9334d809426] Merge branch 'for-6.1/google' into for-linus
git bisect good cb7c02e91c31f55d08760f04a09bf9334d809426
# good: [02010cf0093629b9eeadade1f2684d85eaa3390f] mfd: ocelot-spi: Add missing MODULE_DEVICE_TABLE
git bisect good 02010cf0093629b9eeadade1f2684d85eaa3390f
# bad: [72a95859728a7866522e6633818bebc1c2519b17] mfd: syscon: Remove repetition of the regmap_get_val_endian()
git bisect bad 72a95859728a7866522e6633818bebc1c2519b17
# first bad commit: [72a95859728a7866522e6633818bebc1c2519b17] mfd: syscon: Remove repetition of the regmap_get_val_endian()