lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 9 Oct 2022 20:21:46 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Jiangshan Yi <13667453960@....com>
Cc:     linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Jiangshan Yi <yijiangshan@...inos.cn>,
        k2ci <kernel-bot@...inos.cn>
Subject: Re: [PATCH] staging: rtl8723bs: fix spelling typo in comment

On Sun, Oct 09, 2022 at 02:56:47PM +0800, Jiangshan Yi wrote:
> From: Jiangshan Yi <yijiangshan@...inos.cn>

Then why is this being sent from a 163.com address?

What is wrong with using your real mail server?

> 
> Fix spelling typo in comment.
> 
> K2ci (Kylin Continuous Integration) is a code pre-verification tool
> independently developed by KylinSoft, which is used for ensuring the
> code quality of code submission. K2ci includes the comment check tool
> notes_check.
> 
> This spelling typo was found using notes_check tool.
> 
> Reported-by: k2ci <kernel-bot@...inos.cn>
> Signed-off-by: Jiangshan Yi <yijiangshan@...inos.cn>
> ---
>  drivers/staging/rtl8723bs/core/rtw_cmd.c     | 2 +-
>  drivers/staging/rtl8723bs/core/rtw_efuse.c   | 2 +-
>  drivers/staging/rtl8723bs/include/sta_info.h | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> index d3f10a3cf972..a421c430164a 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
> @@ -1656,7 +1656,7 @@ u8 rtw_c2h_packet_wk_cmd(struct adapter *padapter, u8 *pbuf, u16 length)
>  	return res;
>  }
>  
> -/* dont call R/W in this function, beucase SDIO interrupt have claim host */
> +/* don't call R/W in this function, because SDIO interrupt have claim host */

That is not a spelling fix, but rather a "punctuation" fix if you want
to be picky :)

>  /* or deadlock will happen and cause special-systemserver-died in android */
>  u8 rtw_c2h_wk_cmd(struct adapter *padapter, u8 *c2h_evt)
>  {
> diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> index 06e727ce9cc2..71800917d132 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> @@ -277,7 +277,7 @@ bool		bPseudoTest)
>  	return bResult;
>  }
>  
> -/*  11/16/2008 MH Write one byte to reald Efuse. */
> +/*  11/16/2008 MH Write one byte to real Efuse. */

The date should just be removed entirely, right?

>  u8 efuse_OneByteWrite(struct adapter *padapter, u16 addr, u8 data, bool bPseudoTest)
>  {
>  	u8 tmpidx = 0;
> diff --git a/drivers/staging/rtl8723bs/include/sta_info.h b/drivers/staging/rtl8723bs/include/sta_info.h
> index 69c377eeeaf0..1c3f83867cb0 100644
> --- a/drivers/staging/rtl8723bs/include/sta_info.h
> +++ b/drivers/staging/rtl8723bs/include/sta_info.h
> @@ -190,7 +190,7 @@ struct sta_info {
>  
>  	/* ODM_STA_INFO_T */
>  	/*  ================ODM Relative Info ======================= */
> -	/*  Please be care, dont declare too much structure here. It will cost memory * STA support num. */
> +	/*  Please be care, don't declare too much structure here. It will cost memory * STA support num. */

Same here.

thanks,

greg k-h

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ