linux-kernel - Re: [PATCH 2/3] device property: add {device,fwnode}_property_match_string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 10 Oct 2022 02:40:14 +0800
From:   kernel test robot <lkp@...el.com>
To:     Soha Jin <soha@...u.info>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     kbuild-all@...ts.01.org, "Rafael J. Wysocki" <rafael@...nel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Daniel Scally <djrscally@...il.com>,
        Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        linux-kernel@...r.kernel.org, Soha Jin <soha@...u.info>
Subject: Re: [PATCH 2/3] device property: add
 {device,fwnode}_property_match_string_nocase()

Hi Soha,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on driver-core/driver-core-testing]
[also build test WARNING on sailus-media-tree/streams linus/master v6.0 next-20221007]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Soha-Jin/Case-insensitive-match_string-and-fwnode_is_compatible/20221010-002529
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git a6afa4199d3d038fbfdff5511f7523b0e30cb774
config: um-i386_defconfig
compiler: gcc-11 (Debian 11.3.0-5) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/436baf20c2b3f0a9f4eb7f4c11df3b2c4488d060
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Soha-Jin/Case-insensitive-match_string-and-fwnode_is_compatible/20221010-002529
        git checkout 436baf20c2b3f0a9f4eb7f4c11df3b2c4488d060
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=um SUBARCH=i386 SHELL=/bin/bash drivers/base/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/base/property.c:468:5: warning: no previous prototype for 'fwnode_property_do_match_string' [-Wmissing-prototypes]
     468 | int fwnode_property_do_match_string(const struct fwnode_handle *fwnode,
         |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/fwnode_property_do_match_string +468 drivers/base/property.c

   467	
 > 468	int fwnode_property_do_match_string(const struct fwnode_handle *fwnode,
   469		const char *propname, const char *string,
   470		int (*cmp)(const char *, const char *))
   471	{
   472		const char **values;
   473		int nval, ret;
   474	
   475		nval = fwnode_property_read_string_array(fwnode, propname, NULL, 0);
   476		if (nval < 0)
   477			return nval;
   478	
   479		if (nval == 0)
   480			return -ENODATA;
   481	
   482		values = kcalloc(nval, sizeof(*values), GFP_KERNEL);
   483		if (!values)
   484			return -ENOMEM;
   485	
   486		ret = fwnode_property_read_string_array(fwnode, propname, values, nval);
   487		if (ret < 0)
   488			goto out;
   489	
   490		ret = __match_string(values, nval, string, cmp);
   491		if (ret < 0)
   492			ret = -ENODATA;
   493	out:
   494		kfree(values);
   495		return ret;
   496	}
   497	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (41466 bytes)