lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 9 Oct 2022 21:55:49 +0300 From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org> To: Marijn Suijten <marijn.suijten@...ainline.org>, phone-devel@...r.kernel.org, Rob Clark <robdclark@...il.com>, Abhinav Kumar <quic_abhinavk@...cinc.com>, Vinod Koul <vkoul@...nel.org> Cc: ~postmarketos/upstreaming@...ts.sr.ht, AngeloGioacchino Del Regno <angelogioacchino.delregno@...ainline.org>, Konrad Dybcio <konrad.dybcio@...ainline.org>, Martin Botka <martin.botka@...ainline.org>, Jami Kettunen <jami.kettunen@...ainline.org>, Sean Paul <sean@...rly.run>, David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>, Douglas Anderson <dianders@...omium.org>, Vladimir Lypak <vladimir.lypak@...il.com>, linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org, freedreno@...ts.freedesktop.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v3 05/10] drm/msm/dsi: Appropriately set dsc->mux_word_size based on bpc On 09/10/2022 21:48, Marijn Suijten wrote: > This field is currently unread but will come into effect when duplicated > code below is migrated to call drm_dsc_compute_rc_parameters(), which > uses the bpc-dependent value of the local variable mux_words_size in > much the same way. > > The hardcoded constant seems to be a remnant from the `/* bpc 8 */` > comment right above, indicating that this group of field assignments is > applicable to bpc = 8 exclusively and should probably bail out on > different bpc values, until constants for other bpc values are added (or > the current ones are confirmed to be correct across multiple bpc's). > > Fixes: b9080324d6ca ("drm/msm/dsi: add support for dsc data") > Signed-off-by: Marijn Suijten <marijn.suijten@...ainline.org> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org> -- With best wishes Dmitry
Powered by blists - more mailing lists