linux-kernel - Re: [PATCH v4 2/2] irqchip/apple-aic: Add support for A7-A11 SoCs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87wn99hl10.wl-maz@kernel.org>
Date:   Sun, 09 Oct 2022 01:56:43 +0100
From:   Marc Zyngier <maz@...nel.org>
To:     Konrad Dybcio <konrad.dybcio@...ainline.org>
Cc:     ~postmarketos/upstreaming@...ts.sr.ht, asahi@...ts.linux.dev,
        Hector Martin <marcan@...can.st>,
        Sven Peter <sven@...npeter.dev>,
        Alyssa Rosenzweig <alyssa@...enzweig.io>,
        martin.botka@...ainline.org,
        angelogioacchino.delregno@...ainline.org,
        marijn.suijten@...ainline.org, jamipkettunen@...ainline.org,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/2] irqchip/apple-aic: Add support for A7-A11 SoCs

On Sat, 08 Oct 2022 08:03:23 +0100,
Konrad Dybcio <konrad.dybcio@...ainline.org> wrote:
> 
> 
> 
> On 8.10.2022 01:17, Marc Zyngier wrote:
> > On 2022-10-07 21:00, Konrad Dybcio wrote:
> >> Add support for A7-A11 SoCs by if-ing out some features only present
> >> on A11 & newer (implementation-defined IPI & UNCORE registers).
> >>
> >> Also, annotate IPI regs support in the aic struct so that the driver
> >> can tell whether the SoC supports these, as they are written to,
> >> even if fast IPI is disabled. This in turn causes a crash on older
> >> platforms, as the implemention-defined registers either do
> >> something else or are not supposed to be touched - definitely not a
> >> NOP though.
> >>
> >> Signed-off-by: Konrad Dybcio <konrad.dybcio@...ainline.org>
> >> ---
> >> Changes since v3:
> >> - Replace use_fast_ipi with has_uncore_ipi_regs in aic_init_cpu
> >> (logic error, this was written to regardless of FIPI usage before,
> >> but touching Sn_... regs on SoCs that don't explicitly use them for
> >> IPIs makes them sepuku..)
> >> - Drop A11 compatible
> >>
> >>  drivers/irqchip/irq-apple-aic.c | 47 ++++++++++++++++++++++-----------
> >>  1 file changed, 32 insertions(+), 15 deletions(-)
> > 
> > Since you cannot be bothered to read the review comments on
> > the previous versions of this series, I'll do the same with
> > these patches. Feel free to stop Cc-ing me.
> > 
> >         M.
> I'm sorry, I'm working on a lot of stuff right now and I was almost sure
> your email only concerned adding a cover letter

And yet you ignored it again.

> and affirming the discussion on the fallback compatible,

I couldn't care less about that, but I admire your ability to guess
what an email may or may not contain!

> so I did not go through it again - but that was
> obviously incorrect. If you don't mind, I can respin another version of this
> patchset, addressing your comments.

That's pretty pointless at the moment, as I'm not queuing anything
other than fixes (and one week between versions is a sensible
pace). Come back after -rc1 with a cover letter and the various
comments addressed.

	M.

-- 
Without deviation from the norm, progress is not possible.