linux-kernel - Re: [PATCH v4 14/14] tty: gunyah: Add tty console driver for RM Console Services

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 10 Oct 2022 11:06:30 -0700
From:   Elliot Berman <quic_eberman@...cinc.com>
To:     Jiri Slaby <jirislaby@...nel.org>,
        Bjorn Andersson <quic_bjorande@...cinc.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     Murali Nalajala <quic_mnalajal@...cinc.com>,
        Trilok Soni <quic_tsoni@...cinc.com>,
        Srivatsa Vaddagiri <quic_svaddagi@...cinc.com>,
        Carl van Schaik <quic_cvanscha@...cinc.com>,
        Andy Gross <agross@...nel.org>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Jassi Brar <jassisinghbrar@...il.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        "Mark Rutland" <mark.rutland@....com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Sudeep Holla <sudeep.holla@....com>,
        "Marc Zyngier" <maz@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@...aro.org>,
        Jonathan Corbet <corbet@....net>,
        Will Deacon <will@...nel.org>,
        Catalin Marinas <catalin.marinas@....com>,
        Arnd Bergmann <arnd@...db.de>, <devicetree@...r.kernel.org>,
        <linux-doc@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 14/14] tty: gunyah: Add tty console driver for RM
 Console Services


On 10/3/2022 12:01 AM, Jiri Slaby wrote:
> On 28. 09. 22, 21:56, Elliot Berman wrote:
>> +struct rm_cons_port {
>> +    struct tty_port port;
>> +    u16 vmid;
>> +    bool open;
>> +    unsigned int index;
>> +
>> +    DECLARE_KFIFO(put_fifo, char, 1024);
> 
> Why is tty_port::xmit_fifo not enough?
> 

xmit_fifo gave me some inspiration to avoid using KFIFO here and skip 
extra an extra memcpy into/out of the FIFO.

I've also dropped out the FIFO usage for tty_operations and this 
buffering is only used for printk console.

Thanks,
Elliot