linux-kernel - Re: [PATCH] cgroup: Fix crash with CLONE_INTO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 10 Oct 2022 08:48:48 -1000
From:   Tejun Heo <tj@...nel.org>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     Christian Brauner <brauner@...nel.org>,
        "Christian A. Ehrhardt" <lk@...e.de>,
        syzbot <syzbot+534ee3d24c37c411f37f@...kaller.appspotmail.com>,
        linux-kernel@...r.kernel.org, syzkaller-bugs@...glegroups.com,
        Yosry Ahmed <yosryahmed@...gle.com>
Subject: Re: [PATCH] cgroup: Fix crash with CLONE_INTO_CGROUP and v1 cgroups

On Sun, Oct 09, 2022 at 08:16:29PM +0200, Greg KH wrote:
> On Sun, Oct 09, 2022 at 07:35:19PM +0200, Christian Brauner wrote:
> > On Sun, Oct 09, 2022 at 03:10:36PM +0200, Christian A. Ehrhardt wrote:
> > > 
> > > Since commit f3a2aebdd6, Version 1 cgroups no longer cause an
> > > error when used with CLONE_INTO_CGROUP. However, the permission
> > > checks performed during clone assume a Version 2 cgroup.
> > > 
> > > Restore the error check for V1 cgroups in the clone() path.
> > > 
> > > Reported-by: syzbot+534ee3d24c37c411f37f@...kaller.appspotmail.com
> > > Link: https://lore.kernel.org/lkml/000000000000385cbf05ea3f1862@google.com/
> > > Fixes: f3a2aebdd6 ("cgroup: enable cgroup_get_from_file() on cgroup1")
> > > Signed-off-by: Christian A. Ehrhardt <lk@...e.de>
> > > ---
> > 
> > Thanks for fixing this,
> > Reviewed-by: Christian Brauner (Microsoft) <brauner@...nel.org>
> 
> No cc: stable?  :(

This got merged this cycle, so no need for -stable.

Thanks.

-- 
tejun