linux-kernel - Re: [PATCH v2] riscv: fix styling in ucontext header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 10 Oct 2022 21:41:08 +0100
From:   Conor Dooley <conor@...nel.org>
To:     Cleo John <waterdev@...axycrow.de>
Cc:     Paul Walmsley <paul.walmsley@...ive.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] riscv: fix styling in ucontext header

On Mon, Oct 10, 2022 at 09:55:17PM +0200, Cleo John wrote:
> Am Montag, 10. Oktober 2022, 20:50:56 CEST schrieb Conor Dooley:
> > On Mon, Oct 10, 2022 at 08:28:48PM +0200, Cleo John wrote:
> > > Change the two comments in ucontext.h by getting them up to
> > > the coding style proposed by torvalds.
> > > 
> > > Signed-off-by: Cleo John <waterdev@...axycrow.de>
> > > ---
> > > In my opinion this also improves the readability so I think this is a useful change to do.
> > > Please also tell me if you have a different opinion.
> > 
> > I don't think it is all that /important/ of a change, but it does make
> > things match between this file and the other headers.
> > Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>
> > 
> > Thanks.
> > 
> 
> Yes, its not that important. Thats why I chose it. :D

:)

> To be honest this is my first commit to the kernel so 
> I wanted to do something simple to start things of
> easy and to get more familiar with the procedure,
> before getting my feet wet into some real kernel
> additions.

Cool, nice to have you & good luck!

> Thanks for helping!

nw, hopefully I wasn't too direct/negative.

Conor.

> 
> > > 
> > > Changes in v2:
> > >  - change the styling of the top comments too
> > > 
> > >  arch/riscv/include/uapi/asm/ucontext.h | 12 ++++++++----
> > >  1 file changed, 8 insertions(+), 4 deletions(-)
> > > 
> > > diff --git a/arch/riscv/include/uapi/asm/ucontext.h b/arch/riscv/include/uapi/asm/ucontext.h
> > > index 44eb993950e5..516bd0bb0da5 100644
> > > --- a/arch/riscv/include/uapi/asm/ucontext.h
> > > +++ b/arch/riscv/include/uapi/asm/ucontext.h
> > > @@ -15,19 +15,23 @@ struct ucontext {
> > >  	struct ucontext	 *uc_link;
> > >  	stack_t		  uc_stack;
> > >  	sigset_t	  uc_sigmask;
> > > -	/* There's some padding here to allow sigset_t to be expanded in the
> > > +	/*
> > > +	 * There's some padding here to allow sigset_t to be expanded in the
> > >  	 * future.  Though this is unlikely, other architectures put uc_sigmask
> > >  	 * at the end of this structure and explicitly state it can be
> > > -	 * expanded, so we didn't want to box ourselves in here. */
> > > +	 * expanded, so we didn't want to box ourselves in here.
> > > +	 */
> > >  	__u8		  __unused[1024 / 8 - sizeof(sigset_t)];
> > > -	/* We can't put uc_sigmask at the end of this structure because we need
> > > +	/*
> > > +	 * We can't put uc_sigmask at the end of this structure because we need
> > >  	 * to be able to expand sigcontext in the future.  For example, the
> > >  	 * vector ISA extension will almost certainly add ISA state.  We want
> > >  	 * to ensure all user-visible ISA state can be saved and restored via a
> > >  	 * ucontext, so we're putting this at the end in order to allow for
> > >  	 * infinite extensibility.  Since we know this will be extended and we
> > >  	 * assume sigset_t won't be extended an extreme amount, we're
> > > -	 * prioritizing this. */
> > > +	 * prioritizing this.
> > > +	 */
> > >  	struct sigcontext uc_mcontext;
> > >  };
> > >  
> > 
>