[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Mon, 10 Oct 2022 09:52:11 +0800
From: Chunyan Zhang <zhang.lyra@...il.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Linus Walleij <linus.walleij@...aro.org>,
Bartosz Golaszewski <bgolaszewski@...libre.com>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
Baolin Wang <baolin.wang7@...il.com>,
Orson Zhai <orsonzhai@...il.com>,
Chunyan Zhang <chunyan.zhang@...soc.com>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2 2/3] dt-bindings: gpio: Convert Unisoc EIC controller
binding to yaml
On Sun, 9 Oct 2022 at 23:17, Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> On 08/10/2022 04:57, Chunyan Zhang wrote:
> >>> + eic_debounce: gpio@...10000 {
> >>> + compatible = "sprd,sc9860-eic-debounce";
> >>> + reg = <0 0x40210000 0 0x80>;
> >>> + gpio-controller;
> >>> + #gpio-cells = <2>;
> >>> + interrupt-controller;
> >>> + #interrupt-cells = <2>;
> >>> + interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>;
> >>> + };
> >>> + };
> >>> +
> >>> + sc2730_pmic {
> >>
> >> If you insisted to keep it, at least should be correct, so just pmic.
> >>
> >>> + #address-cells = <1>;
> >>> + #size-cells = <0>;
> >>> +
> >>> + pmic_eic: gpio@300 {
> >>
> >> It's exactly the same example as above - all same properties. Drop it or
> >> bring some differences.
> >
> > The differences are on #address-cells and #size-cells.
> >
>
> Which don't really matter...
Alright, will drop it in the next version.
>
> Best regards,
> Krzysztof
>
Powered by blists - more mailing lists