linux-kernel - Re: [PATCH v2] arc: iounmap() arg is volatile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <593925a6-66d3-42bf-19d3-2f54917892ce@kernel.org>
Date:   Sun, 9 Oct 2022 21:44:07 -0700
From:   Vineet Gupta <vgupta@...nel.org>
To:     Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc:     Vineet Gupta <vgupta@...nel.org>,
        linux-snps-arc@...ts.infradead.org, Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v2] arc: iounmap() arg is volatile

On 10/9/22 19:28, Randy Dunlap wrote:
> Add 'volatile' to iounmap()'s argument to prevent build warnings.
> This make it the same as other major architectures.
>
> Placates these warnings: (12 such warnings)
>
> ../drivers/video/fbdev/riva/fbdev.c: In function 'rivafb_probe':
> ../drivers/video/fbdev/riva/fbdev.c:2067:42: error: passing argument 1 of 'iounmap' discards 'volatile' qualifier from pointer target type [-Werror=discarded-qualifiers]
>   2067 |                 iounmap(default_par->riva.PRAMIN);
>
> Fixes: 1162b0701b14b ("ARC: I/O and DMA Mappings")
> Signed-off-by: Randy Dunlap<rdunlap@...radead.org>
> Cc: Vineet Gupta<vgupta@...nel.org>
> Cc:linux-snps-arc@...ts.infradead.org
> Cc: Arnd Bergmann<arnd@...db.de>

Thx for the fix. On for-curr.

-Vineet