linux-kernel - RE: [PATCH] usb: cdns3: adjust the partial logic of cdnsp_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 10 Oct 2022 04:27:15 +0000
From:   Pawel Laszczak <pawell@...ence.com>
To:     Dongliang Mu <dzm91@...t.edu.cn>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] usb: cdns3: adjust the partial logic of cdnsp_pci_remove

>
>In cdnsp_pci_remove, if pci_is_enabled returns true, it will
>call cdns_remove; else it will call kfree. Then both control flow
>goes to pci_dev_put.
>
>Adjust this logic by modifying it to an if else.
>

Acked-by: Pawel Laszczak <pawell@...ence.com>

Thanks
Pawel,

>Signed-off-by: Dongliang Mu <dzm91@...t.edu.cn>
>---
> drivers/usb/cdns3/cdnsp-pci.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
>diff --git a/drivers/usb/cdns3/cdnsp-pci.c b/drivers/usb/cdns3/cdnsp-pci.c
>index fe8a114c586c..efd54ed918b9 100644
>--- a/drivers/usb/cdns3/cdnsp-pci.c
>+++ b/drivers/usb/cdns3/cdnsp-pci.c
>@@ -192,14 +192,12 @@ static void cdnsp_pci_remove(struct pci_dev *pdev)
> 	if (pci_dev_run_wake(pdev))
> 		pm_runtime_get_noresume(&pdev->dev);
>
>-	if (!pci_is_enabled(func)) {
>+	if (pci_is_enabled(func)) {
>+		cdns_remove(cdnsp);
>+	} else {
> 		kfree(cdnsp);
>-		goto pci_put;
> 	}
>
>-	cdns_remove(cdnsp);
>-
>-pci_put:
> 	pci_dev_put(func);
> }
>
>--
>2.25.1