linux-kernel - Re: [PATCH v2 34/40] arm64: dts: qcom: sm6125: align TLMM pin configuration with DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d97b7d32-6e27-5a04-336b-0af6bd92c83c@linaro.org>
Date:   Mon, 10 Oct 2022 06:26:52 -0400
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Marijn Suijten <marijn.suijten@...ainline.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Iskren Chernev <iskren.chernev@...il.com>,
        Martin Botka <martin.botka@...ainline.org>,
        Vinod Koul <vkoul@...nel.org>, linux-arm-msm@...r.kernel.org,
        linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 34/40] arm64: dts: qcom: sm6125: align TLMM pin
 configuration with DT schema

On 09/10/2022 13:46, Marijn Suijten wrote:
>> diff --git a/arch/arm64/boot/dts/qcom/sm6125.dtsi b/arch/arm64/boot/dts/qcom/sm6125.dtsi
>> index 8c582a9e4ada..1fe3fa3ad877 100644
>> --- a/arch/arm64/boot/dts/qcom/sm6125.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm6125.dtsi
>> @@ -387,19 +387,19 @@ tlmm: pinctrl@...000 {
>>  			#interrupt-cells = <2>;
>>  
>>  			sdc2_off_state: sdc2-off-state {
>> -				clk {
>> +				clk-pins {
>>  					pins = "sdc2_clk";
>>  					drive-strength = <2>;
>>  					bias-disable;
>>  				};
>>  
>> -				cmd {
>> +				cmd-pins {
>>  					pins = "sdc2_cmd";
>>  					drive-strength = <2>;
>>  					bias-pull-up;
>>  				};
>>  
>> -				data {
>> +				data-pins {
>>  					pins = "sdc2_data";
>>  					drive-strength = <2>;
>>  					bias-pull-up;
>> @@ -413,13 +413,13 @@ clk {
>>  					bias-disable;
>>  				};
>>  
>> -				cmd {
>> +				cmd-pins-pins {
> 
> Is this double -pins-pins suffix intended?
> 

No, thanks for noticing it.

Best regards,
Krzysztof