[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 10 Oct 2022 14:45:23 +0200
From: Takashi Iwai <tiwai@...e.de>
To: "Luke D. Jones" <luke@...nes.dev>
Cc: linux-kernel@...r.kernel.org, alsa-devel@...a-project.org,
tiwai@...e.com, perex@...ex.cz
Subject: Re: [PATCH] Fixes bc2c23549ccd ("ALSA: hda/realtek: Add pincfg for ASUS G533Z HP jack")
On Mon, 10 Oct 2022 08:57:02 +0200,
Luke D. Jones wrote:
>
> The initial fix for ASUS G533Z was based on faulty information. This
> fixes the pincfg to values that have been verified with no existing
> module options or other hacks enabled.
>
> Enables headphone jack, and 5.1 surround.
>
> Signed-off-by: Luke D. Jones <luke@...nes.dev>
The changes look OK, but the subject line should be rather describing
what about the patch is about. I corrected the subject and put the
proper Fixes tag (as well as Cc-to-stable).
Also, the indent level wasn't right, so I corrected it locally, too.
thanks,
Takashi
Powered by blists - more mailing lists