[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Mon, 10 Oct 2022 14:14:10 +0100
From: Lukasz Luba <lukasz.luba@....com>
To: Cristian Marussi <cristian.marussi@....com>
Cc: sudeep.holla@....com, james.quinlan@...adcom.com,
Jonathan.Cameron@...wei.com, f.fainelli@...il.com,
etienne.carriere@...aro.org, vincent.guittot@...aro.org,
daniel.lezcano@...aro.org, tarek.el-sherbiny@....com,
adrian.slatineanu@....com, souvik.chakravarty@....com,
wleavitt@...vell.com, wbartczak@...vell.com,
dan.carpenter@...cle.com, "Rafael J . Wysocki" <rafael@...nel.org>,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-pm@...r.kernel.org
Subject: Re: [PATCH v2 1/3] powercap: arm_scmi: Add SCMI Powercap based driver
Hi Cristian,
On 9/6/22 15:23, Cristian Marussi wrote:
> Add a powercap driver that, using the ARM SCMI Protocol to query the SCMI
> platform firmware for the list of existing Powercap domains, registers all
> of such discovered domains under the new 'arm-scmi' powercap control type.
>
> A new simple powercap zone and constraint is registered for all the SCMI
> powercap zones that are found.
>
> Cc: Rafael J. Wysocki <rafael@...nel.org>
> Cc: linux-pm@...r.kernel.org
> Signed-off-by: Cristian Marussi <cristian.marussi@....com>
> ---
> v1 --> v2
> - using clamp_t() to simplify normalizations
> - cleanup style in block of var declarations
> - refactor scale conversions code
> - add MAINTAINER entry
> - refactored normalizations and added dev_dbg
> vOLD --> v1
> - fix _init cleaning up powerctrl zone on failure
> - removed uneeded casting
> - simplified normalization helpers
> ---
> MAINTAINERS | 1 +
> drivers/powercap/Kconfig | 13 +
> drivers/powercap/Makefile | 1 +
> drivers/powercap/arm_scmi_powercap.c | 508 +++++++++++++++++++++++++++
> 4 files changed, 523 insertions(+)
> create mode 100644 drivers/powercap/arm_scmi_powercap.c
>
Thanks for addressing my comments.
The code LGTM
Reviewed-by: Lukasz Luba <lukasz.luba@....com>
Regards,
Lukasz
Powered by blists - more mailing lists