linux-kernel - RE: [PATCH] net: mdiobus: add fwnode_phy_is_fixed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <08616A924F416E8E+327e01d8dcbf$2237dbe0$66a793a0$@lohu.info>
Date:   Mon, 10 Oct 2022 23:44:06 +0800
From:   "Soha Jin" <soha@...u.info>
To:     "'Andrew Lunn'" <andrew@...n.ch>
Cc:     "'Heiner Kallweit'" <hkallweit1@...il.com>,
        "'David S. Miller'" <davem@...emloft.net>,
        "'Eric Dumazet'" <edumazet@...gle.com>,
        "'Jakub Kicinski'" <kuba@...nel.org>,
        "'Paolo Abeni'" <pabeni@...hat.com>,
        "'Russell King'" <linux@...linux.org.uk>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] net: mdiobus: add fwnode_phy_is_fixed_link()

Hello Andrew,

> From: Andrew Lunn <andrew@...n.ch>
> Sent: Monday, October 10, 2022 11:03 PM
> 
> On Mon, Oct 10, 2022 at 12:20:06AM +0800, Soha Jin wrote:
> > A helper function to check if PHY is fixed link with fwnode properties.
> > This is similar to of_phy_is_fixed_link.
> 
> You need to include a user of this new function.

Greg already notified me about this. I was thinking this patch and my
driver patches are on different trees, so I split the patches into
different parts. I will include this patch in my driver patch's v2 later
and ask you to review then. Sorry for the mistake.

> Also, not that ACPI only defines the 'new binding' for fixed-link.  If this is
> being called on a device which is ACPI underneath, it should only return true
> for the 'new binding', not the old binding.

Thanks for the information, I will correct this.

Regards,
Soha