linux-kernel - Re: [PATCH v5 13/13] tty: gunyah: Add tty console driver for RM Console Services

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ff27b168-38f2-9be4-197c-2920b66b1754@quicinc.com>
Date:   Tue, 11 Oct 2022 11:22:36 -0700
From:   Elliot Berman <quic_eberman@...cinc.com>
To:     Jiri Slaby <jirislaby@...nel.org>,
        Bjorn Andersson <quic_bjorande@...cinc.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     Murali Nalajala <quic_mnalajal@...cinc.com>,
        Trilok Soni <quic_tsoni@...cinc.com>,
        Srivatsa Vaddagiri <quic_svaddagi@...cinc.com>,
        Carl van Schaik <quic_cvanscha@...cinc.com>,
        Prakruthi Deepak Heragu <quic_pheragu@...cinc.com>,
        Andy Gross <agross@...nel.org>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Jassi Brar <jassisinghbrar@...il.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        Mark Rutland <mark.rutland@....com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Sudeep Holla <sudeep.holla@....com>,
        Marc Zyngier <maz@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Jonathan Corbet <corbet@....net>,
        "Will Deacon" <will@...nel.org>,
        Catalin Marinas <catalin.marinas@....com>,
        "Arnd Bergmann" <arnd@...db.de>, <devicetree@...r.kernel.org>,
        <linux-doc@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 13/13] tty: gunyah: Add tty console driver for RM
 Console Services



On 10/10/2022 11:02 PM, Jiri Slaby wrote:
>> +    char *co_xmit_buf[2];
>> +    int co_xmit_idx;
>> +    unsigned int co_xmit_count;
>> +    spinlock_t co_xmit_lock;
>> +    struct work_struct co_flush_work;
>> +};
>> +
>> +static int rm_cons_notif_handler(struct notifier_block *nb, unsigned 
>> long cmd, void *data)
>> +{
>> +    int count, i;
>> +    struct rm_cons_port *rm_port = NULL;
>> +    struct tty_port *tty_port = NULL;
>> +    struct rm_cons_drv_data *cons_data =
>> +        container_of(nb, struct rm_cons_drv_data, rm_cons_notif);
>> +    const struct gh_rm_notification *notif = data;
>> +    struct gh_rm_notif_vm_console_chars const * const msg = notif->buff;
> 
> So you did not comment on/address all my notes?
> 

Apologies Jiri, I wanted to get some consensus on direction to take the 
RM console driver and missed out the sorting here.