linux-kernel - Re: [PATCH v6 5/7] treewide: use get_random

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y0XCCSpBVcfg/C/7@zx2c4.com>
Date:   Tue, 11 Oct 2022 13:20:41 -0600
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Rolf Eike Beer <eike-kernel@...tec.de>
Cc:     linux-kernel@...r.kernel.org, patches@...ts.linux.dev,
        Andrew Morton <akpm@...ux-foundation.org>,
        "David S . Miller" <davem@...emloft.net>,
        kernel-janitors@...r.kernel.org, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH v6 5/7] treewide: use get_random_u32() when possible

On Tue, Oct 11, 2022 at 11:14:44AM +0200, Rolf Eike Beer wrote:
> Am Dienstag, 11. Oktober 2022, 01:06:11 CEST schrieb Jason A. Donenfeld:
> > The prandom_u32() function has been a deprecated inline wrapper around
> > get_random_u32() for several releases now, and compiles down to the
> > exact same code. Replace the deprecated wrapper with a direct call to
> > the real function. The same also applies to get_random_int(), which is
> > just a wrapper around get_random_u32(). This was done as a basic find
> > and replace.
> 
> > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pno.c
> > b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pno.c index
> > d0a7465be586..3a7aded30e8e 100644
> > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pno.c
> > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pno.c
> > @@ -177,7 +177,7 @@ static int brcmf_pno_set_random(struct brcmf_if *ifp,
> > struct brcmf_pno_info *pi) memcpy(pfn_mac.mac, mac_addr, ETH_ALEN);
> >  	for (i = 0; i < ETH_ALEN; i++) {
> >  		pfn_mac.mac[i] &= mac_mask[i];
> > -		pfn_mac.mac[i] |= get_random_int() & ~(mac_mask[i]);
> > +		pfn_mac.mac[i] |= get_random_u32() & ~(mac_mask[i]);
> >  	}
> >  	/* Clear multi bit */
> >  	pfn_mac.mac[0] &= 0xFE;
> 
> mac is defined as u8 mac[ETH_ALEN]; in fwil_types.h.
> 
> Eike
> 
> P.S.: CC list trimmed because of an unrelated mailer bug

Nice catch, thanks. Will remove to the get_random_{u16,u8} commit.