lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 11 Oct 2022 21:50:33 +0200 From: Philipp Hortmann <philipp.g.hortmann@...il.com> To: Rui Li <me@...ui.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org Subject: Re: [PATCH v3] staging: rtl8192e: remove unnecessary braces for single statement blocks On 10/10/22 01:21, Rui Li wrote: > This commit cleans up checkpatch warning as follows: > braces {} are not necessary for single statement blocks > > Signed-off-by: Rui Li <me@...ui.org> > --- > Changes since v2: > - Correct commit message title > - Add changelog > > Changes since v1: > - Only fix one of checkpatch warnings > --- > drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 3 +-- > drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c | 9 +++------ > drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 12 ++++-------- > 3 files changed, 8 insertions(+), 16 deletions(-) > > diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c > index 18e4e5d84878..8d20b0deca37 100644 > --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c > +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c > @@ -1112,9 +1112,8 @@ void rtl92e_fill_tx_desc(struct net_device *dev, struct tx_desc *pdesc, > if (cb_desc->bHwSec) { > static u8 tmp; > > - if (!tmp) { > + if (!tmp) > tmp = 1; > - } > switch (priv->rtllib->pairwise_key_type) { > case KEY_TYPE_WEP40: > case KEY_TYPE_WEP104: > diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c > index 1b592258e640..4e3d183be0f2 100644 > --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c > +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_phy.c > @@ -522,9 +522,8 @@ static bool _rtl92e_bb_config_para_file(struct net_device *dev) > rtStatus = rtl92e_check_bb_and_rf(dev, > (enum hw90_block)eCheckItem, > (enum rf90_radio_path)0); > - if (!rtStatus) { > + if (!rtStatus) > return rtStatus; > - } > } > rtl92e_set_bb_reg(dev, rFPGA0_RFMOD, bCCKEn|bOFDMEn, 0x0); > _rtl92e_phy_config_bb(dev, BaseBand_Config_PHY_REG); > @@ -1379,9 +1378,8 @@ static bool _rtl92e_set_rf_power_state(struct net_device *dev, > i++; > } > > - if (i >= MAX_DOZE_WAITING_TIMES_9x) { > + if (i >= MAX_DOZE_WAITING_TIMES_9x) > break; > - } > } > rtl92e_set_rf_off(dev); > break; > @@ -1398,9 +1396,8 @@ static bool _rtl92e_set_rf_power_state(struct net_device *dev, > i++; > } > > - if (i >= MAX_DOZE_WAITING_TIMES_9x) { > + if (i >= MAX_DOZE_WAITING_TIMES_9x) > break; > - } > } > > if (pPSC->RegRfPsLevel & RT_RF_OFF_LEVL_HALT_NIC && > diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c > index 702551056227..641961a14c52 100644 > --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c > +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c > @@ -267,9 +267,8 @@ static void _rtl92e_dm_check_ac_dc_power(struct net_device *dev) > "PATH=/usr/bin:/bin", > NULL}; > > - if (priv->ResetProgress == RESET_TYPE_SILENT) { > + if (priv->ResetProgress == RESET_TYPE_SILENT) > return; > - } > > if (priv->rtllib->state != RTLLIB_LINKED) > return; > @@ -330,9 +329,8 @@ static void _rtl92e_dm_check_rate_adaptive(struct net_device *dev) > bool bshort_gi_enabled = false; > static u8 ping_rssi_state; > > - if (!priv->up) { > + if (!priv->up) > return; > - } > > if (pra->rate_adaptive_disabled) > return; > @@ -777,9 +775,8 @@ static void _rtl92e_dm_tx_power_tracking_cb_thermal(struct net_device *dev) > tmpRegA = rtl92e_get_bb_reg(dev, rOFDM0_XATxIQImbalance, > bMaskDWord); > for (i = 0; i < OFDM_Table_Length; i++) { > - if (tmpRegA == OFDMSwingTable[i]) { > + if (tmpRegA == OFDMSwingTable[i]) > priv->OFDM_index[0] = i; > - } > } > > TempCCk = rtl92e_get_bb_reg(dev, rCCK0_TxFilter1, bMaskByte2); > @@ -1066,9 +1063,8 @@ void rtl92e_dm_restore_state(struct net_device *dev) > u32 reg_ratr = priv->rate_adaptive.last_ratr; > u32 ratr_value; > > - if (!priv->up) { > + if (!priv->up) > return; > - } > > if (priv->rate_adaptive.rate_adaptive_disabled) > return; Tested-by: Philipp Hortmann <philipp.g.hortmann@...il.com>
Powered by blists - more mailing lists