linux-kernel - Re: [PATCH 1/1] scripts/clang-tools: Convert clang-tidy args to list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKwvOdmsjxB_i=9Qy6L+4AH+CwOYa0EsRBPFUTj9vwxJ6vNPSg@mail.gmail.com>
Date:   Tue, 11 Oct 2022 13:34:44 -0700
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     Guru Das Srinagesh <quic_gurus@...cinc.com>,
        Masahiro Yamada <masahiroy@...nel.org>
Cc:     Nathan Chancellor <nathan@...nel.org>, Tom Rix <trix@...hat.com>,
        Elliot Berman <quic_eberman@...cinc.com>,
        John Moon <quic_johmoo@...cinc.com>, llvm@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] scripts/clang-tools: Convert clang-tidy args to list

On Tue, Oct 11, 2022 at 12:06 PM Guru Das Srinagesh
<quic_gurus@...cinc.com> wrote:
>
> Convert list of clang-tidy arguments to a list for ease of adding to
> them and extending them as required.
>
> Signed-off-by: Guru Das Srinagesh <quic_gurus@...cinc.com>
> Suggested-by: Nick Desaulniers <ndesaulniers@...gle.com>

Thanks for the patch!
Reviewed-by: Nick Desaulniers <ndesaulniers@...gle.com>

Masahiro, would you please be able to carry this up through the kbuild tree?

> ---
>  scripts/clang-tools/run-clang-tools.py | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/scripts/clang-tools/run-clang-tools.py b/scripts/clang-tools/run-clang-tools.py
> index bb78c9b..56f2ec8 100755
> --- a/scripts/clang-tools/run-clang-tools.py
> +++ b/scripts/clang-tools/run-clang-tools.py
> @@ -45,13 +45,14 @@ def init(l, a):
>
>  def run_analysis(entry):
>      # Disable all checks, then re-enable the ones we want
> -    checks = "-checks=-*,"
> +    checks = []
> +    checks.append("-checks=-*")
>      if args.type == "clang-tidy":
> -        checks += "linuxkernel-*"
> +        checks.append("linuxkernel-*")
>      else:
> -        checks += "clang-analyzer-*"
> -        checks += ",-clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling"
> -    p = subprocess.run(["clang-tidy", "-p", args.path, checks, entry["file"]],
> +        checks.append("clang-analyzer-*")
> +        checks.append("-clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling")
> +    p = subprocess.run(["clang-tidy", "-p", args.path, ",".join(checks), entry["file"]],
>                         stdout=subprocess.PIPE,
>                         stderr=subprocess.STDOUT,
>                         cwd=entry["directory"])
> --
> 2.7.4
>


-- 
Thanks,
~Nick Desaulniers