[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20221011025426.xocfhvvkakdc4jzo@vireshk-i7>
Date: Tue, 11 Oct 2022 08:24:26 +0530
From: Viresh Kumar <viresh.kumar@...aro.org>
To: Perry Yuan <Perry.Yuan@....com>
Cc: rafael.j.wysocki@...el.com, ray.huang@....com,
Deepak.Sharma@....com, Mario.Limonciello@....com,
Nathan.Fontenot@....com, Alexander.Deucher@....com,
Shimmer.Huang@....com, Xiaojian.Du@....com, Li.Meng@....com,
linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH V2 7/9] cpufreq: amd_pstate: add AMD Pstate EPP
support for the MSR based processors
On 11-10-22, 00:22, Perry Yuan wrote:
> +static void amd_pstate_update_max_freq(unsigned int cpu)
> +{
> + struct cpufreq_policy *policy = cpufreq_cpu_acquire(cpu);
Why isn't cpufreq_cpu_get() enough here ? cpufreq_cpu_acquire() is
special as it takes policy->rwsem as well and you shouldn't need it.
> +
> + if (!policy)
> + return;
> +
> + refresh_frequency_limits(policy);
> + cpufreq_cpu_release(policy);
> +}
--
viresh
Powered by blists - more mailing lists